Mix/Add nodes breaks Eevee AO render pass if one socket is unfilled. #88779

Open
opened 2021-06-03 07:00:28 +02:00 by Cici · 6 comments
Contributor

System Information
Operating system: Windows-10-10.0.16299-SP0 64 Bits
Graphics card: GeForce RTX 2070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 419.67

Blender Version
Broken: version: 2.92.0, 2.93.0, 3.0 0efb627bbd

Short description of error
In Eevee, any material which contains an add shader node will be broken in the AO pass, if second socket is invalid, leaving the material either entirely black or white.
This is annoying if you're creating entirely black materials by leaving a socket empty.

Exact steps for others to reproduce the error

  • Add a mesh, give it a material.
  • Put either an an add shader node or a mix node into the material somewhere, but only fill one of the input sockets
  • Enable AO with Eevee, and look at the AO render pass in render view. In 2.92, the object will be completely black, in 2.93 it will completely white.

  • Render the scene with the file given.
  • For the second case, render by swapping the socket inputs of the "Add Shader" node.
    T88779_mine.blend

image.png
image.png

Additional example images.
(2.93)
F10155389
F10155391

(2.92)
F10155385

**System Information** Operating system: Windows-10-10.0.16299-SP0 64 Bits Graphics card: GeForce RTX 2070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 419.67 **Blender Version** Broken: version: 2.92.0, 2.93.0, 3.0 0efb627bbd **Short description of error** In Eevee, any material which contains an add shader node will be broken in the AO pass, if second socket is *invalid*, leaving the material either entirely black or white. This is annoying if you're creating entirely black materials by leaving a socket empty. **Exact steps for others to reproduce the error** - Add a mesh, give it a material. - Put either an an add shader node or a mix node into the material somewhere, but only fill one of the input sockets - Enable AO with Eevee, and look at the AO render pass in render view. In 2.92, the object will be completely black, in 2.93 it will completely white. ---------------- - Render the scene with the file given. - For the second case, render by swapping the socket inputs of the "Add Shader" node. [T88779_mine.blend](https://archive.blender.org/developer/F10181417/T88779_mine.blend) ![image.png](https://archive.blender.org/developer/F10181120/image.png) ![image.png](https://archive.blender.org/developer/F10181118/image.png) Additional example images. (2.93) [F10155389](https://archive.blender.org/developer/F10155389/image.png) [F10155391](https://archive.blender.org/developer/F10155391/image.png) (2.92) [F10155385](https://archive.blender.org/developer/F10155385/image.png)
Author
Contributor

Added subscriber: @Consta

Added subscriber: @Consta
Member

Added subscriber: @ankitm

Added subscriber: @ankitm
Member

Changed status from 'Needs Triage' to: 'Needs User Info'

Changed status from 'Needs Triage' to: 'Needs User Info'
Member

Please attach a simple blend file to show the issue.
Or see mine. I can't redo completely white object in AO pass if one input of mix shader is left empty.
macOS 10.14, 0efb627bbd

image.png
T88779_mine.blend

Please attach a simple blend file to show the issue. Or see mine. I can't redo completely white object in AO pass if one input of mix shader is left empty. macOS 10.14, 0efb627bbd ![image.png](https://archive.blender.org/developer/F10180542/image.png) [T88779_mine.blend](https://archive.blender.org/developer/F10180551/T88779_mine.blend)
Author
Contributor

After some fiddling with your file I've found that if any part of a shader tree has the bottom socket evaluate to an "invalid" material (IE from an empty shader input socket) AO will break on that material.
This does not occur if the top input is "invalid", AO will be fine regardless of input or lack of input.
This is true for both mix and add.
image.png
image.png

After some fiddling with your file I've found that if any part of a shader tree has the bottom socket evaluate to an "invalid" material (IE from an empty shader input socket) AO will break on that material. This does not occur if the top input is "invalid", AO will be fine regardless of input or lack of input. This is true for both mix and add. ![image.png](https://archive.blender.org/developer/F10181118/image.png) ![image.png](https://archive.blender.org/developer/F10181120/image.png)
Member

Changed status from 'Needs User Info' to: 'Confirmed'

Changed status from 'Needs User Info' to: 'Confirmed'
Philipp Oeser removed the
Interest
EEVEE & Viewport
label 2023-02-09 15:13:38 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#88779
No description provided.