Wrong undo/redo sequence with direct transform change (via Item/transform panel or addon) #90234

New Issue

Vyacheslav Kobozev · 2021-07-27T12:38:50+02:00

2021-07-27 12:38:50 +02:00

System Information
Operating system: Windows-8.1-6.3.9600-SP0 64 Bits
Graphics card: GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 375.70

Blender Version
Broken: version: 2.93.1, branch: master, commit date: 2021-06-22 05:57, hash: 1b8d33b18c

Short description of error
Undo operation is not working properly with Copy attributes addon.
[refer the video to understand the situation better]

Exact steps to Reproduce the error

2021-07-28_13-59-32.mp4

To reproduce

1. Make sphere, go to sculpt mode.
1. Draw «1» on sphere
1. Change location via item panel
1. Draw «3» on the sphere
1. Undo actions with {key Ctrl+Z}: undo order is broken

Exact steps to Reproduce the error (Addon Case)

Open .blend file
Enable Copy attributes addon
Select both mesh objects
Do {key Ctrl C} -> Copy Locations
Switch to edit mode
Perform some changes to the mesh
Switch to object mode
Perform undo operation.

[Notice that the undo operation ignores all the steps from edit mode and directly switches the mesh to the initial position]

2021-07-27_13-33-38.mp4

Test File:
#90234.blend

**System Information** Operating system: Windows-8.1-6.3.9600-SP0 64 Bits Graphics card: GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 375.70 **Blender Version** Broken: version: 2.93.1, branch: master, commit date: 2021-06-22 05:57, hash: `1b8d33b18c` **Short description of error** Undo operation is not working properly with `Copy attributes addon`. [refer the video to understand the situation better] **Exact steps to Reproduce the error** [2021-07-28_13-59-32.mp4](https://archive.blender.org/developer/F10242874/2021-07-28_13-59-32.mp4) **To reproduce** - 0. Make sphere, go to sculpt mode. - 1. Draw «1» on sphere - 2. Change location via item panel - 3. Draw «3» on the sphere - 4. Undo actions with {key Ctrl+Z}: undo order is broken --- **Exact steps to Reproduce the error (Addon Case)** - Open .blend file - Enable Copy attributes addon - Select both mesh objects - Do {key Ctrl C} -> `Copy Locations` - Switch to edit mode - Perform some changes to the mesh - Switch to object mode - Perform undo operation. [Notice that the undo operation ignores all the steps from edit mode and directly switches the mesh to the initial position] [2021-07-27_13-33-38.mp4](https://archive.blender.org/developer/F10240502/2021-07-27_13-33-38.mp4) Test File: [#90234.blend](https://archive.blender.org/developer/F10242730/T90234.blend)

Vyacheslav Kobozev commented

2021-07-27 12:38:50 +02:00

Added subscriber: @Vyach

Eugene Du commented

2021-07-27 21:30:51 +02:00

Added subscriber: @APEC

Pratik Borhade commented

2021-07-28 05:54:57 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2021-07-28 05:54:57 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2021-07-28 05:54:57 +02:00

I can confirm with 3.0.0 (6ee14c966d)

I can confirm with 3.0.0 (`6ee14c966d`)

Bastien Montagne commented

2021-07-28 10:22:44 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2021-07-28 10:22:44 +02:00

Changed status from 'Confirmed' to: 'Needs User Info'

Bastien Montagne commented

2021-07-28 10:22:44 +02:00

@PratikPB2123 The task as it is is not acceptable.

If you took the time to watch the video and actually understand what is going on, then please edit the report and add usual expected info (clear description of the issue, steps to reproduce, etc.)

Also, if this is only reproducible with an add-on, and not 'vanilla' Blender, then it is most likely an add-on issue, please do not add core and such tags to it then.

@PratikPB2123 The task as it is is not acceptable. If you took the time to watch the video and actually understand what is going on, then please edit the report and add usual expected info (clear description of the issue, steps to reproduce, etc.) Also, if this is only reproducible with an add-on, and not 'vanilla' Blender, then it is most likely an add-on issue, please do not add core and such tags to it then.

Pratik Borhade commented

2021-07-28 10:30:15 +02:00

Hi @mont29 . Issue only happens with Copy attribute addon.

please do not add core and such tags to it then.

The problem is related to Undo operation so I added the #core module. (my apologies if I did the mistake)

then please edit the report and add usual expected info

Thought video itself is enough to describe the problem. Ok, I will edit the report.

Hi @mont29 . Issue only happens with `Copy attribute addon`. >please do not add core and such tags to it then. The problem is related to Undo operation so I added the #core module. (my apologies if I did the mistake) >then please edit the report and add usual expected info Thought video itself is enough to describe the problem. Ok, I will edit the report.

Vyacheslav Kobozev commented

2021-07-28 13:05:32 +02:00

Okay, I tested with sculpt mode.
As I thought bug is not related to addon. For some reason object mode actions and edit/sculpt mode actions loose proper order in undo sequence.

2021-07-28_13-59-32.mp4

To reproduce
0. Make sphere, go to sculpt mode.

Draw «1» on sphere
Change location via item panel
Draw «3» on the sphere
Undo actions with {key Ctrl+Z}: undo order is broken

@PratikPB2123 thanks for editing, not much time to do it…

Okay, I tested with sculpt mode. As I thought bug is not related to addon. For some reason object mode actions and edit/sculpt mode actions loose proper order in undo sequence. [2021-07-28_13-59-32.mp4](https://archive.blender.org/developer/F10242874/2021-07-28_13-59-32.mp4) **To reproduce** 0. Make sphere, go to sculpt mode. 1. Draw «1» on sphere 2. Change location via item panel 3. Draw «3» on the sphere 4. Undo actions with {key Ctrl+Z}: undo order is broken @PratikPB2123 thanks for editing, not much time to do it…

Pratik Borhade commented

2021-08-05 06:10:10 +02:00

Added subscriber: @lichtwerk

Pratik Borhade commented

2021-08-05 06:10:10 +02:00

The task as it is is not acceptable.

Any news? Looks like a bug to me.

@lichtwerk , can you please check this?

> The task as it is is not acceptable. Any news? Looks like a bug to me. @lichtwerk , can you please check this?

Vyacheslav Kobozev changed title from ~~Wrong undo/redo sequence with Copy attributes addon~~ to Wrong undo/redo sequence with direct transform change (via Item/transform panel or addon)

2021-08-05 13:10:51 +02:00

Garek commented

2021-08-15 09:50:29 +02:00

Added subscriber: @Garek

Garek commented

2021-08-15 09:50:29 +02:00

Can reproduce with 2.92, 2.80 and 2.79b.
Test that I made:

Add an object such as sphere
Change object properties via Properties panel
Change to Sculpt mode
Change properties second time
Use stroke on an object
Change properties third time
Use stroke second time
Undo all actions
Redo all actions

Incorrect undo-redo.avi

Expected behavior on step 8: reverse steps in order 7, 6, 5, 4, 3, 2.
Factual behavior on step 8: reverse steps 7, 5 (strokes), then steps 6-4-3 (object properties via Properties panel and change to sculpt mode) all at the same time, then step 2.

Expected behavior on step 9 (taking into account wrong behavior in step 8): redo step 2, then steps 3-4-6 (object properties via Properties panel and change to sculpt mode) all at the same time, then steps 5, 7.
Factual behavior on step 9: redo step 2, 3, 5, 7 (steps 4, 6 lost completely).

Can reproduce with 2.92, 2.80 and 2.79b. Test that I made: 1. Add an object such as sphere 2. Change object properties via `Properties` panel 3. Change to Sculpt mode 4. Change properties second time 5. Use stroke on an object 6. Change properties third time 7. Use stroke second time 8. Undo all actions 9. Redo all actions [Incorrect undo-redo.avi](https://archive.blender.org/developer/F10282289/Incorrect_undo-redo.avi) **Expected behavior on step 8**: reverse steps in order 7, 6, 5, 4, 3, 2. **Factual behavior on step 8**: reverse steps 7, 5 (strokes), then steps 6-4-3 (object properties via `Properties` panel and change to sculpt mode) *all at the same time*, then step 2. **Expected behavior on step 9 (taking into account wrong behavior in step 8)**: redo step 2, then steps 3-4-6 (object properties via `Properties` panel and change to sculpt mode) all at the same time, then steps 5, 7. **Factual behavior on step 9**: redo step 2, 3, 5, 7 (steps 4, 6 lost completely).

Philipp Oeser commented

2021-08-16 08:35:30 +02:00

Changed status from 'Needs User Info' to: 'Confirmed'

Ryan Inch commented

2022-02-13 02:42:51 +01:00

Added subscriber: @Imaginer

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Wrong undo/redo sequence with direct transform change (via Item/transform panel or addon) #90234