Graph Editor menu item Key -> Clean Channels and Key -> Clean Keyframes have the same descriptive text #91133

New Issue

Jason schleifer · 2021-09-02T19:17:36+02:00

Jason schleifer commented

2021-09-02 19:17:36 +02:00

System Information
Operating system: macOS-11.5.2-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 560X OpenGL Engine ATI Technologies Inc. 4.1 ATI-4.6.20

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-08-31 17:17, hash: 838b6ec48a
Worked: none

Short description of error
The graph editor menu item Key -> Clean Channels and Key -> Clean Keyframes have the same descriptive text when they do two different things.
Key -> Clean Channels help text should be changed to Clears keyframes on channels that have default values.

Exact steps for others to reproduce the error
Create some animation on the default cube
open the graph editor
select the curves
Choose the Key menu
Hover over the Clean Channels and Clean Keyframes menu items to see the text.

**System Information** Operating system: macOS-11.5.2-x86_64-i386-64bit 64 Bits Graphics card: AMD Radeon Pro 560X OpenGL Engine ATI Technologies Inc. 4.1 ATI-4.6.20 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-08-31 17:17, hash: `838b6ec48a` Worked: none **Short description of error** The graph editor menu item Key -> Clean Channels and Key -> Clean Keyframes have the same descriptive text when they do two different things. Key -> Clean Channels help text should be changed to Clears keyframes on channels that have default values. **Exact steps for others to reproduce the error** Create some animation on the default cube open the graph editor select the curves Choose the Key menu Hover over the Clean Channels and Clean Keyframes menu items to see the text.

Jason schleifer commented

2021-09-02 19:17:36 +02:00

Added subscriber: @JasonSchleifer

Pratik Borhade commented

2021-09-03 08:30:21 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2021-09-03 08:30:25 +02:00

Added subscriber: @PratikPB2123

Philipp Oeser commented

2021-09-03 10:30:59 +02:00

Added subscriber: @lichtwerk

Philipp Oeser self-assigned this 2021-09-03 10:30:59 +02:00

Philipp Oeser commented

2021-09-03 10:53:13 +02:00

Hold on, the Clean Channels still simplifies the F-Curve, no?

So description should be "Simplify F-Curves by removing closely spaced keyframes and clear keyframes on channels that have default values", right?

Hold on, the `Clean Channels` still simplifies the F-Curve, no? So description should be "Simplify F-Curves by removing closely spaced keyframes and clear keyframes on channels that have default values", right?

Philipp Oeser commented

2021-09-20 13:02:00 +02:00

As discussed in D12387: Fix #91133: clarify Animation 'Clean Channels' and 'Clean Keyframes' description, this needs a bit of a decision whether the operator itself should also be changed:

In D12387 #326336, @dr.sybren wrote:
I've added this to the agenda of today's module meeting, maybe we can come to a decision on what behaviour is desired, and then tackle the vagueness of the description and the behaviour all at once.

As discussed in [D12387: Fix #91133: clarify Animation 'Clean Channels' and 'Clean Keyframes' description](https://archive.blender.org/developer/D12387), this needs a bit of a decision whether the operator itself should also be changed: > In [D12387](https://archive.blender.org/developer/D12387)#326336, @dr.sybren wrote: > I've added this to [the agenda of today's module meeting](https://devtalk.blender.org/t/2021-09-16-animation-rigging-meeting-upcoming/20467), maybe we can come to a decision on what behaviour is desired, and then tackle the vagueness of the description and the behaviour all at once.

Philipp Oeser commented

2021-09-20 13:02:20 +02:00

Added subscriber: @dr.sybren

Philipp Oeser commented

2021-09-20 13:03:26 +02:00

@dr.sybren: was there a chance to discuss this at the meeting?

Philipp Oeser removed their assignment 2021-11-12 09:09:39 +01:00

Philipp Oeser commented

2021-11-12 09:09:39 +01:00

Think this needs more of a design decision now (in regards to the behavior of the operator -- seems like the operator itself cannot stay the way it is), see also discussion in D12387
Since this is a bit out of my scope, I will step down to not block others.

Think this needs more of a design decision now (in regards to the behavior of the operator -- seems like the operator itself cannot stay the way it is), see also discussion in [D12387](https://archive.blender.org/developer/D12387) Since this is a bit out of my scope, I will step down to not block others.

RedMser commented

2022-05-16 17:35:43 +02:00

Added subscriber: @RedMser

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Graph Editor menu item Key -> Clean Channels and Key -> Clean Keyframes have the same descriptive text #91133