Handling of appending collections that contain linked materials has changed from 2.93 to 3.0, no longer works as expected #92224
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#92224
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Mac OS Big Sur Version 11.6
Graphics card: AMD Radeon Pro 5500M 8 GB
Blender Version
Broken: 3.0.0 Alpha
Worked: 2.93.3
Caused by
3be5ce4aad
Short description of error
When using bpy.ops.wm.append on a collection from a file with materials linked from other file, all appended objects now come in as linked, previously objects would be appended and linked materials would come in as links.
Exact steps for others to reproduce the error
linking_example.zip
append_me
collectionLocalize All
unchecked (this will link the objects in the collection [wrong])In blender 2.93 the objects appended into scene will be editable, but the materials on them will still be links to the original material file.
In 3.0 the objects will all be linked and non editable, or, if localize all is selected the materials will be localized rather than linked. As far as I can tell there is no way to get the objects to append while keeping the materials linked
Added subscriber: @casey_recogni
Added subscriber: @lichtwerk
Changed status from 'Needs Triage' to: 'Needs User Info'
Hm, cannot reproduce here.
I have used this:
If I do this in 3.0, Sphere is editable, material is localized (link to material file vanishes when saving and reopening that file)
Same If I do this in 2.93.5 [with the exception that
do_reuse_local_id
is not available there].Could you share the exact code you are using?
{F11150819}{F11150729}Sure thing, to clarify though, what I'm looking for is the sphere to be editable and the materials to NOT be localized
at the moment when I run this the objects that get appended are editable but the material links are maintained, but in 3.0 either everything gets linked or everything gets localized
I've attached a screenshot of what the structure of the file is after importing stuff, this started as a new file so everything in it is imported
Changed status from 'Needs User Info' to: 'Needs Triage'
Changed status from 'Needs Triage' to: 'Confirmed'
Can confirm now for collections, will check.
This is also the case for doing it via the UI (so not only in the case of using the Python API)
Added subscriber: @mont29
Caused by
3be5ce4aad
CC @mont29
Added subscriber: @dfelinto
Current code is behaving as it should (on a logical level that is), the appended ID is the collection, so this is the only thing that should be made local here.
Note that objects can easily be made local too (from the Outliner e.g.).
Now, on a user experience level, I am not sure... I can see how also getting the collection's objects made local could be an expected/desired behavior here, even when 'localize all' is disabled. But on the other end this breaks the consistency in behavior of this code.
In any case, even if enabled for users, on code level such 'rule breaking' behavior should be optional.
This is more a product design/UX topic, so would rather get @dfelinto and #user_interface inputs on this topic before making any change and adding some custom exception in such code.
Was also talking to @mont29 in chat, but will share my (uneducated) view here:
Localize All
is OFF, new behavior will also leave the lattice linked to the source file (2.93 also made the lattice local)Localize All
says "...including those indirectly linked from other libraries" (guess part of the confusion also comes from "other libraries"), what is libraries? .blend files?Localize All
OFF were to keep links in other files (like in the report: linked materials from .blend B, but localized collections/objects/whatnot from .blend A)Added subscriber: @Jeroen-Bakker
Will also CC @Jeroen-Bakker (since #92315/T91252 might be related?)
@mont29 I don't see a reason for collections to be treated differently than other datablocks. Users can always hand-pick which objects to make local after appending the collection itself.
Changed status from 'Confirmed' to: 'Archived'
@lichtwerk I do not see how dealing with external files would be related to dealing with (indirectly) linked IDs...
Anyway, this is behaving as expected now. Again, you can make the objects local as needed from e.g. the Outliner.
Will add a note to the release notes about the change of behavior though. thanks for the report.
Sorry, I was misreading #92315/T91252 as dealing with external/linked .blend files (will go back to my corner).
Guess I will have to live with the new behavior (still thinking about the usecase where you would want
Localize All
being OFF in 3.0 when dealing with collections at all now though...)To repeat: afaics, the workflow up to and including 2.93 [which was beneficial and working fine on my end] was that you could append from .blend A and everything from that .blend was localized but if in turn .blend A linked from .blend B those were still links
Changed status from 'Archived' to: 'Confirmed'
@lichtwerk Uuuuh thanks for that precision, that was indeed not clear to me at all until now (I thought it was only a weird quirk in objects handling, not a systematic consistent behavior for all ID types).
That change in behavior was not intended, and only happened due to misunderstanding of confusing code...
There could be two options, either revert to previous behavior, or add a new option to control whether to locallize all IDs from same library (2.93 behavior) or only strictly selected ones (3.0 current behavior).
Talked with @dfelinto, we agreed that for now it was simpler to revert to 2.93 behavior, as it is unclear whether new one is really useful in practice and it breaks existing workflows for no good reasons.
This issue was referenced by
b3b7319de7
Changed status from 'Confirmed' to: 'Resolved'