Inconsistent Grease Pencil auto-keying behavior #93248

New Issue

Sam Brubaker · 2021-11-20T21:29:29+01:00

Sam Brubaker commented

2021-11-20 21:29:29 +01:00

System Information
Operating system: Linux 64-bit
Graphics card: GTX 1080

Blender Version
3.1 and prior

Short description of error
When auto-keying is enabled and you're transforming a GP stroke in edit mode on a new frame, a keyframe is added at the beginning of the operation before it is confirmed. If you right-click to cancel the operation, the redundant keyframe remains. This is inconsistent with auto-keying in every other area, in which Blender waits for the user to confirm the operation before adding the keyframe.

Also, deleting a stroke fails to add a new keyframe. I apologize if these are two different bugs but they seem related.
GP_autokey_bug.blend
Exact steps for others to reproduce the error

Open the attached file.
Grab (G) a stroke, then right-click to cancel moving it. The keyframe was inserted, even though no change was made.

Go to another frame, then delete a stroke. No keyframe was inserted this time, even though the GP drawing has definitely changed!

**System Information** Operating system: Linux 64-bit Graphics card: GTX 1080 **Blender Version** 3.1 and prior **Short description of error** When auto-keying is enabled and you're transforming a GP stroke in edit mode on a new frame, a keyframe is added at the beginning of the operation before it is confirmed. If you right-click to cancel the operation, the redundant keyframe remains. This is inconsistent with auto-keying in every other area, in which Blender waits for the user to confirm the operation before adding the keyframe. Also, deleting a stroke fails to add a new keyframe. I apologize if these are two different bugs but they seem related. [GP_autokey_bug.blend](https://archive.blender.org/developer/F11833917/GP_autokey_bug.blend) **Exact steps for others to reproduce the error** - Open the attached file. - Grab (G) a stroke, then right-click to cancel moving it. The keyframe was inserted, even though no change was made. # Go to another frame, then delete a stroke. No keyframe was inserted this time, even though the GP drawing has definitely changed!

Sam Brubaker commented

2021-11-20 21:29:29 +01:00

Added subscriber: @rocketman

Pratik Borhade commented

2021-11-22 11:21:59 +01:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2021-11-22 11:33:26 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2021-11-22 11:38:06 +01:00

Added subscriber: @lichtwerk

Philipp Oeser self-assigned this 2021-11-22 11:38:06 +01:00

Philipp Oeser commented

2021-11-22 11:38:06 +01:00

Can confirm, will check.

Philipp Oeser removed their assignment 2021-11-22 13:04:03 +01:00

Philipp Oeser commented

2021-11-22 13:04:03 +01:00

Added subscribers: @filedescriptor, @antoniov

Philipp Oeser commented

2021-11-22 13:04:03 +01:00

Turns out this (canceling out of transform) is a bit hairy for greasepencil:

Opposed to other transform operations (which insert their auto-keyframes as part of special_aftertrans_update__XXX [and only do so if transform was not cancelled], greasepencil does this early on [and it probably needs to] as part of createTransGPencil_curves/createTransGPencil_strokes.
So we could introduce a special_aftertrans_update__gpencil and remove the frame again (but then again, dont think there is an easy way to figure out if the frame might have existed beforehand?)

Have not looked into the auto-key for deleting, but since this might involve a rethinking of design, would prefer if @antoniov or @filedescriptor have a look...

Turns out this (canceling out of transform) is a bit hairy for greasepencil: Opposed to other transform operations (which insert their auto-keyframes as part of `special_aftertrans_update__XXX` [and only do so if transform was not cancelled], greasepencil does this early on [and it probably needs to] as part of `createTransGPencil_curves`/`createTransGPencil_strokes`. So we could introduce a `special_aftertrans_update__gpencil` and remove the frame again (but then again, dont think there is an easy way to figure out if the frame might have existed beforehand?) Have not looked into the auto-key for deleting, but since this might involve a rethinking of design, would prefer if @antoniov or @filedescriptor have a look...

Martin Capitanio commented

2021-11-22 14:41:44 +01:00

Added subscriber: @capnm

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Inconsistent Grease Pencil auto-keying behavior #93248

Go to another frame, then delete a stroke. No keyframe was inserted this time, even though the GP drawing has definitely changed!