Saved keymap changes do not remove "Restore" button #94178

Open
opened 2021-12-17 07:21:33 +01:00 by Ludvik Koutny · 6 comments
Contributor

System Information
Operating system: Windows-10-10.0.19042-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.76

Blender Version
Broken: version: 3.0.0, branch: SelectThrough (modified), commit date: 2021-12-15 12:21, hash: 6349dd43b1
Worked: (newest version of Blender that worked as expected)

Short description of error
When editing Keymaps, the keymaps very often incorrectly show "Restore" button even though there is no difference between saved and active keymap. This is very frustrating as it constantly keeps the user uncertain about the state of the keymap and often leads to corruption of keymaps due to unintended changes.

Exact steps for others to reproduce the error

  1. Make a copy of a default keymap and save it under a new name.
  2. Make modifications to this new keymap
  3. Using the + button, save the the modified keymap under the same name to overwrite it
  4. Notice the "Restore" buttons under keymap entries are still present
  5. Open any section with the "Restore" button and then click it. Observe no changes to the section.
    Result: Restore button is still present but it does not restore any changes. This makes user think the given section is modified, while it is not.
    Expected: Restore buttons do not appear next to section with no changed entries.

OR:

  1. Make a copy of a default keymap and save it under a new name.
  2. Make modifications to this new keymap
  3. Export this new keymap into a file
  4. Import this keymap back from the file to overwrite it
  5. Notice the "Restore" buttons under keymap entries are still present
  6. Open any section with the "Restore" button and then click it. Observe no changes to the section.
    Result: Restore button is still present but it does not restore any changes. This makes user think the given section is modified, while it is not.
    Expected: Restore buttons do not appear next to section with no changed entries.
**System Information** Operating system: Windows-10-10.0.19042-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.76 **Blender Version** Broken: version: 3.0.0, branch: SelectThrough (modified), commit date: 2021-12-15 12:21, hash: `6349dd43b1` Worked: (newest version of Blender that worked as expected) **Short description of error** When editing Keymaps, the keymaps very often incorrectly show "Restore" button even though there is no difference between saved and active keymap. This is very frustrating as it constantly keeps the user uncertain about the state of the keymap and often leads to corruption of keymaps due to unintended changes. **Exact steps for others to reproduce the error** 1. Make a copy of a default keymap and save it under a new name. 2. Make modifications to this new keymap 3. Using the + button, save the the modified keymap under the same name to overwrite it 4. Notice the "Restore" buttons under keymap entries are still present 5. Open any section with the "Restore" button and then click it. Observe no changes to the section. Result: Restore button is still present but it does not restore any changes. This makes user think the given section is modified, while it is not. Expected: Restore buttons do not appear next to section with no changed entries. OR: 1. Make a copy of a default keymap and save it under a new name. 2. Make modifications to this new keymap 3. Export this new keymap into a file 4. Import this keymap back from the file to overwrite it 5. Notice the "Restore" buttons under keymap entries are still present 6. Open any section with the "Restore" button and then click it. Observe no changes to the section. Result: Restore button is still present but it does not restore any changes. This makes user think the given section is modified, while it is not. Expected: Restore buttons do not appear next to section with no changed entries.
Author
Contributor

Added subscriber: @Rawalanche

Added subscriber: @Rawalanche
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123

Added subscriber: @Hologram

Added subscriber: @Hologram

Yesterday, I noticed that there were still keymaps from the Booltool present in my keymap, after having uninstalled the addon over a year ago. When I removed the entries, I could not remove one of the items. Though after saving my preferences, the restore button was still there, when I clicked on it, all of the booltool shortcuts I had previously removed, returned. So this can have unforseen consequences even after saving preferences!

Yesterday, I noticed that there were still keymaps from the Booltool present in my keymap, after having uninstalled the addon over a year ago. When I removed the entries, I could not remove one of the items. Though after saving my preferences, the restore button was still there, when I clicked on it, all of the booltool shortcuts I had previously removed, returned. So this can have unforseen consequences even after saving preferences!
Philipp Oeser removed the
Interest
User Interface
label 2023-02-10 09:22:36 +01:00
Member

Guess we need to clear KEYMAP_USER_MODIFIED flag when preferences are saved or when new/export button is pressed. But I suspect that might affect the default blender preference as well. I'll check further

Guess we need to clear `KEYMAP_USER_MODIFIED` flag when preferences are saved or when new/export button is pressed. But I suspect that might affect the default blender preference as well. I'll check further
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#94178
No description provided.