Regression: Group Input/Output cannot connect to some custom sockets #94827

New Issue

Joseph Brandenburg · 2022-01-11T20:09:17+01:00

2022-01-11 20:09:17 +01:00

System Information
Operating system:
Graphics card:

Blender Version
Broken: 2.97.7 hash fb762eedbe or earlier (haven't bisected it), Blender 3.0
Worked: (optional) 2.93.6 Release hash : c842a90e2f

Caused by a5c59fb90e

Short description of error
Group Input/ Output nodes cannot connect to some sockets. This doesn't seem to affect built-in types. It doesn't seem to affect every kind of custom socket, either, although I can't find any pattern in what works and doesn't.
The addon Sorcar is affected by this bug. So is my (not yet released) addon.
To make it clear: This worked in past Blenders. It broke sometime between 2.97.6 and 2.97.7. It is broken in 3.0.
May be related somehow to #75959

Exact steps for others to reproduce the error
From this .blend file:
nodes_bug_minimal_example.blend
Try to make a group with Ctrl-G

In versions affected by the bug, the group creation operator will fail when trying to connect a socket to the Group Node, which should get a new input/output for each socket connected to its Group-Input and Group-Output nodes, respectively. However, some sockets can't connect, and this fails without raising an error, so there are no sockets in the Group Node to connect to, which actually does raise an error -- these are both calls to the same Python function. One fails silently, due to this bug.
Anyhow, after the error occurs in making the node group, try and manually connect the nodes to the custom socket, then to the ordinary sockets.
To be clear: The Python script in the .blend file is a demonstration of the bug as it occurs out in the wild... I'm not asking for help fixing the Python script!

I think this may be a regression bug.

**System Information** Operating system: Graphics card: **Blender Version** Broken: 2.97.7 hash fb762eedbe85 or earlier (haven't bisected it), Blender 3.0 Worked: (optional) 2.93.6 Release hash : c842a90e2fa1 Caused by a5c59fb90e **Short description of error** Group Input/ Output nodes cannot connect to some sockets. This doesn't seem to affect built-in types. It doesn't seem to affect every kind of custom socket, either, although I can't find any pattern in what works and doesn't. The addon Sorcar is affected by this bug. So is my (not yet released) addon. To make it clear: This **worked** in past Blenders. It broke sometime between 2.97.6 and 2.97.7. It is broken in 3.0. May be related somehow to #75959 **Exact steps for others to reproduce the error** From this .blend file: [nodes_bug_minimal_example.blend](https://archive.blender.org/developer/F12801458/nodes_bug_minimal_example.blend) Try to make a group with Ctrl-G In versions affected by the bug, the group creation operator will fail when trying to connect a socket to the Group Node, which should get a new input/output for each socket connected to its Group-Input and Group-Output nodes, respectively. However, some sockets can't connect, and this fails **without raising an error**, so there are no sockets in the Group Node to connect to, which actually does raise an error -- these are both calls to the same Python function. One fails silently, due to this bug. Anyhow, after the error occurs in making the node group, try and manually connect the nodes to the custom socket, then to the ordinary sockets. To be clear: The Python script in the .blend file is a demonstration of the bug as it occurs out in the wild... I'm not asking for help fixing the Python script! I think this may be a regression bug.

Joseph Brandenburg commented

2022-01-11 20:09:17 +01:00

Added subscriber: @Josephbburg

Ryan Inch commented

2022-01-12 05:23:45 +01:00

Added subscriber: @Imaginer

Philipp Oeser commented

2022-01-12 15:29:52 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-01-12 15:29:52 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2022-01-12 15:29:52 +01:00

Can confirm (sorry this ended up in LTS), will check how that broke...

Philipp Oeser commented

2022-01-12 15:49:29 +01:00

Added subscriber: @Jeroen-Bakker

Philipp Oeser commented

2022-01-12 15:49:29 +01:00

Caused by a5c59fb90e

CC @Jeroen-Bakker

Caused by a5c59fb90e CC @Jeroen-Bakker

Philipp Oeser changed title from ~~Group Input/Output cannot connect to some sockets in Blender 3.0~~ to Regression: Group Input/Output cannot connect to some custom sockets

2022-01-12 15:50:08 +01:00

Philipp Oeser commented

2022-01-12 16:07:38 +01:00

Added subscribers: @HooglyBoogly, @JacquesLucke

Philipp Oeser commented

2022-01-12 16:07:38 +01:00

Seems like the Group Input sockets happen to be of type SOCK_CUSTOM as well [ and since a5c59fb90e custom py defined sockets are too :) ]

There is a check introduced in 513066e8ad that prevents connections for SOCK_CUSTOM...

Removing the check fixes the issue, but of course brings #39849 back.

Maybe we need a new socket type for group inputs/outputs?

CC @JacquesLucke
CC @HooglyBoogly

Seems like the Group Input sockets happen to be of type `SOCK_CUSTOM` as well [ and since a5c59fb90e custom py defined sockets are too :) ] There is a check introduced in 513066e8ad that prevents connections for `SOCK_CUSTOM`... Removing the check fixes the issue, but of course brings #39849 back. Maybe we need a new socket type for group inputs/outputs? CC @JacquesLucke CC @HooglyBoogly

Philipp Oeser self-assigned this 2022-01-12 16:13:15 +01:00

Philipp Oeser commented

2022-01-12 16:13:15 +01:00

Actually, I think we can just additionally check the node type, will do