Search Menu shows Undo History entries, making it easy to lose work #94976

New Issue

Closed

opened 2022-01-17 14:48:55 +01:00 by Demeter Dzadik · 9 comments

Demeter Dzadik commented

2022-01-17 14:48:55 +01:00

Member

System Information
Operating system: Linux-5.15.11-76051511-generic-x86_64-with-glibc2.34 64 Bits
Graphics card: NVIDIA GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.86

Blender Version
Broken by 0e1bb232e6

Short description of error
When trying to search for an operator, you might end up executing its undo history entry, rolling you back a bunch of steps without you ever realizing that it happened. As soon as you touch anything, your work is lost for ever.

Exact steps for others to reproduce the error

Add Cube
Move, Move, Move
F3, Search for "Add Cube"
One of the entries is from the Undo History, in this case not the top-most one, but in a case with an addon operator I have, the undo history entry can be the top-most one:
Choose that entry. Instead of adding a cube, your cube resets to its original position. Confusing!
Select the cube
Try to undo
Your "Move, Move, Move" steps just got nuked!

**System Information** Operating system: Linux-5.15.11-76051511-generic-x86_64-with-glibc2.34 64 Bits Graphics card: NVIDIA GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.86 **Blender Version** Broken by 0e1bb232e6 **Short description of error** When trying to search for an operator, you might end up executing its undo history entry, rolling you back a bunch of steps without you ever realizing that it happened. As soon as you touch anything, your work is lost for ever. **Exact steps for others to reproduce the error** - Add Cube - Move, Move, Move - F3, Search for "Add Cube" - One of the entries is from the Undo History, in this case not the top-most one, but in a case with an addon operator I have, the undo history entry can be the top-most one: ![image.png](https://archive.blender.org/developer/F12808531/image.png) - Choose that entry. Instead of adding a cube, your cube resets to its original position. Confusing! - Select the cube - Try to undo - Your "Move, Move, Move" steps just got nuked!

Demeter Dzadik commented

2022-01-17 14:48:55 +01:00

Author

Member

Added subscriber: @Mets

Added subscriber: @Mets

Demeter Dzadik commented

2022-01-17 15:01:22 +01:00

Author

Member

On an unrelated note, the Undo History UI got reversed, I don't know if that was by design but if yes, I find that questionable, considering the tail end of the history (which is now the most recent steps) get cut off the screen with 256 steps.

On an unrelated note, the Undo History UI got reversed, I don't know if that was by design but if yes, I find that questionable, considering the tail end of the history (which is now the most recent steps) get cut off the screen with 256 steps.

Pratik Borhade commented

2022-01-18 04:55:28 +01:00

Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-01-18 04:55:28 +01:00

Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2022-01-18 04:55:28 +01:00

Member

I think it has been happening for a couple weeks.

I can confirm on current master. I will search for the commit where it got introduced.

> I think it has been happening for a couple weeks. I can confirm on current master. I will search for the commit where it got introduced.

Demeter Dzadik commented

2022-01-18 15:33:09 +01:00

Author

Member

Dalai beat you do it in the chat! :D Added breaking commit to task description.

Also opened #95024 for the reversed order.

Dalai beat you do it in the chat! :D Added breaking commit to task description. Also opened #95024 for the reversed order.

Campbell Barton was assigned by Demeter Dzadik

2022-01-18 15:34:30 +01:00

blender-admin commented

2022-01-21 06:28:23 +01:00

This issue was referenced by 872dc1038c

This issue was referenced by 872dc1038c42e3d428fac5e6a425c2d788370f58

Pratik Borhade commented

2022-01-21 07:46:52 +01:00

Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'

Pratik Borhade closed this issue

2022-01-21 07:46:52 +01:00

Pratik Borhade commented

2022-01-21 07:46:52 +01:00

Member

Fixed by 872dc1038c

Fixed by 872dc1038c

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#94976

No description provided.