Image editor does not update when you add additional UDIM tiles #96116

New Issue

Jesse Yurkovich · 2022-03-02T03:16:57+01:00

Jesse Yurkovich commented

2022-03-02 03:16:57 +01:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: AMD FirePro W2100 ATI Technologies Inc. 4.5.14831 Core Profile Context FireGL 21.Q2.1 27.20.21026.2006

Blender Version
Broken: version: 3.1.0 Beta, branch: master, commit date: 2022-03-01 23:58, hash: 4932269ec3
Worked: version: 3.1.0 Beta, branch: master, commit date: 2022-02-07 22:08, hash: 229d0ace02 (not the last working build; just the one I had on hand)

Short description of error
Adding new UDIM tiles won't immediately show them in the Image editor until you force the view to refresh (zoom/pan/etc.).

This is similar to other issues recently but this one isn't fixed yet on newest 3.1 build.

Exact steps for others to reproduce the error

Open the image editor
Create a new "Tiled" image
Open up the side panel and add new tiles (see below)
New tiles are added with empty/transparent background

Potential patch -- I'm unsure about the placement of the call as most other uses of this API don't happen in operator exec functions...

diff --git a/source/blender/editors/space_image/image_ops.c b/source/blender/editors/space_image/image_ops.c
index aed4a2ccabd..34fd9120674 100644
--- a/source/blender/editors/space_image/image_ops.c
+++ b/source/blender/editors/space_image/image_ops.c
@@ -3950,10 +3950,11 @@ static int tile_add_exec(bContext *C, wmOperator *op)
     return OPERATOR_CANCELLED;
   }

   ima->active_tile_index = BLI_findindex(&ima->tiles, last_tile_created);

+  BKE_image_partial_update_mark_full_update(ima);
   WM_event_add_notifier(C, NC_IMAGE | ND_DRAW, NULL);
   return OPERATOR_FINISHED;
 }

 static int tile_add_invoke(bContext *C, wmOperator *op, const wmEvent *UNUSED(event))

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: AMD FirePro W2100 ATI Technologies Inc. 4.5.14831 Core Profile Context FireGL 21.Q2.1 27.20.21026.2006 **Blender Version** Broken: version: 3.1.0 Beta, branch: master, commit date: 2022-03-01 23:58, hash: `4932269ec3` Worked: version: 3.1.0 Beta, branch: master, commit date: 2022-02-07 22:08, hash: `229d0ace02` (not the last working build; just the one I had on hand) **Short description of error** Adding new UDIM tiles won't immediately show them in the Image editor until you force the view to refresh (zoom/pan/etc.). This is similar to other issues recently but this one isn't fixed yet on newest 3.1 build. **Exact steps for others to reproduce the error** - Open the image editor - Create a new "Tiled" image - Open up the side panel and add new tiles (see below) - New tiles are added with empty/transparent background Potential patch -- I'm unsure about the placement of the call as most other uses of this API don't happen in operator exec functions... ``` diff --git a/source/blender/editors/space_image/image_ops.c b/source/blender/editors/space_image/image_ops.c index aed4a2ccabd..34fd9120674 100644 --- a/source/blender/editors/space_image/image_ops.c +++ b/source/blender/editors/space_image/image_ops.c @@ -3950,10 +3950,11 @@ static int tile_add_exec(bContext *C, wmOperator *op) return OPERATOR_CANCELLED; } ima->active_tile_index = BLI_findindex(&ima->tiles, last_tile_created); + BKE_image_partial_update_mark_full_update(ima); WM_event_add_notifier(C, NC_IMAGE | ND_DRAW, NULL); return OPERATOR_FINISHED; } static int tile_add_invoke(bContext *C, wmOperator *op, const wmEvent *UNUSED(event)) ``` ![step1.png](https://archive.blender.org/developer/F12893819/step1.png) ![step2.png](https://archive.blender.org/developer/F12893821/step2.png)

Jesse Yurkovich commented

2022-03-02 03:16:57 +01:00

Added subscriber: @deadpin