Grease Pencil Automerge connecting new stroke with strokes that are closed #98235

Closed
opened 2022-05-18 21:08:31 +02:00 by Matthew Gafford · 10 comments

System Information
Operating system: Win10
Graphics card: RTX 3070
Tablet: Xp-Pen Deco 03 (Wireless)

Blender Version
Broken: 3.1
Worked: N/A

Short description of error
When Automerge is enabled, sometimes new strokes get merged with either the starting vertex or the ending vertex of a circular stroke that has been "closed" with the F key.

image.png

Exact steps for others to reproduce the error

  • Draw a Grease Pencil stroke in the shape of a circle, but with a little gap still open.
  • Select the stroke in Edit Mode and hit F key to close the stroke into a full circle.
  • Enable Automerge
  • Draw a stroke that ends near the gap you filled in, either by the starting vertex or the ending vertex (where the gap was filled in)

Video explanation:
https://www.youtube.com/watch?v=79cHYZ2wvys

Blend File:
AutoMergeMergingNewStrokeWithClosedStrokes.blend

**System Information** Operating system: Win10 Graphics card: RTX 3070 Tablet: Xp-Pen Deco 03 (Wireless) **Blender Version** Broken: 3.1 Worked: N/A **Short description of error** When Automerge is enabled, sometimes new strokes get merged with either the starting vertex or the ending vertex of a circular stroke that has been "closed" with the F key. ![image.png](https://archive.blender.org/developer/F13087538/image.png) **Exact steps for others to reproduce the error** - Draw a Grease Pencil stroke in the shape of a circle, but with a little gap still open. - Select the stroke in Edit Mode and hit F key to close the stroke into a full circle. - Enable Automerge - Draw a stroke that ends near the gap you filled in, either by the starting vertex or the ending vertex (where the gap was filled in) Video explanation: https://www.youtube.com/watch?v=79cHYZ2wvys Blend File: [AutoMergeMergingNewStrokeWithClosedStrokes.blend](https://archive.blender.org/developer/F13087537/AutoMergeMergingNewStrokeWithClosedStrokes.blend)

Added subscriber: @AFoxInSpace

Added subscriber: @AFoxInSpace
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123

Added subscriber: @antoniov

Added subscriber: @antoniov

This is a limitation of the algorithm. When you use automerge, the main factor to merge is the distance, and depending of that, the stroke is merged. In general, automerge is not designed to merge with closed shapes, it's more to join a group of strokes that form a full stroke (for example, draw a curved shape drawing small strokes as it's done with a clasic pencil).

This is a limitation of the algorithm. When you use automerge, the main factor to merge is the distance, and depending of that, the stroke is merged. In general, automerge is not designed to merge with closed shapes, it's more to join a group of strokes that form a full stroke (for example, draw a curved shape drawing small strokes as it's done with a clasic pencil).

Added subscriber: @mendio

Added subscriber: @mendio

As you said @antoniov the tool is intended to use only on opened strokes, can we just ignore closed strokes in the algorithm to avoid undesired results?

As you said @antoniov the tool is intended to use only on opened strokes, can we just ignore closed strokes in the algorithm to avoid undesired results?

In #98235#1361303, @mendio wrote:
As you said @antoniov the tool is intended to use only on opened strokes, can we just ignore closed strokes in the algorithm to avoid undesired results?

good point...maybe we could skip closed strokes.

> In #98235#1361303, @mendio wrote: > As you said @antoniov the tool is intended to use only on opened strokes, can we just ignore closed strokes in the algorithm to avoid undesired results? good point...maybe we could skip closed strokes.

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Antonio Vazquez self-assigned this 2022-05-19 18:06:54 +02:00

This issue has been solved in commit 9e9895b055 following the idea of @mendio described above. Now the closed strokes never are merged because it's not logic.

This issue has been solved in commit 9e9895b055d4 following the idea of @mendio described above. Now the closed strokes never are merged because it's not logic.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#98235
No description provided.