Certain operators (relying on context region) crash when called with INVOKE_AREA / EXEC_AREA #98491

New Issue

yonghao lv · 2022-05-30T12:00:21+02:00

yonghao lv commented

2022-05-30 12:00:21 +02:00

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.96

Blender Version
Broken: version: 3.2.0 Beta, branch: master, commit date: 2022-05-26 13:12, hash: bf53956914
Worked: --

Short description of the error
Certain operators (relying on context region) crash when called with INVOKE_AREA / EXEC_AREA

Steps to reproduce
execute this in blenders python console

bpy.ops.console.insert("INVOKE_AREA", text="crash")

So the reason for the crash is that an operator is invoked with INVOKE_AREA here (it does not crash with INVOKE_DEFAULT or any other Execution Context -- except for EXEC_AREA, same thing applies for that one, see below)

If INVOKE_AREA or EXEC_AREA is used, the region gets removed from context, see

      case WM_OP_EXEC_AREA:
      case WM_OP_INVOKE_AREA: {
        /* Remove region from context. */
        ARegion *region = CTX_wm_region(C);

        CTX_wm_region_set(C, nullptr);
        retval = wm_operator_invoke(C, ot, event, properties, reports, poll_only, true);
        CTX_wm_region_set(C, region);

Operators relying on / using region (e.g. via CTX_wm_region) can easily crash then.
Of course we could guard against this with a simple check (and this is done in a couple of places), not sure though if this is the smartest thing to do -- since there are many, many operators that would need the extra treatment...)

Original report
This script is use to check the active material, it can be run correct in the main window, but not popup window(change the pref window to node editor)

import bpy

bpy.ops.screen.userpref_show("INVOKE_AREA")
area = bpy.context.window_manager.windows[-1].screen.areas[0]


area.type = 'NODE_EDITOR'
flip_header = True
area.ui_type = 'ShaderNodeTree'
area.spaces[0].node_tree = bpy.data.materials['Material'].node_tree

for region in area.regions:
    if region.type == 'HEADER':
        with bpy.context.temp_override(area=area, region=region):
            if flip_header: bpy.ops.screen.region_flip('INVOKE_DEFAULT') # this line will not

    if region.type == 'WINDOW':
        with bpy.context.temp_override(area=area, region=region):
            bpy.ops.node.view_all("INVOKE_AREA") # this line will report context error

Exact steps for others to reproduce the error

Open .blend file
Execute script
#98491.blend

**System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.96 **Blender Version** Broken: version: 3.2.0 Beta, branch: master, commit date: 2022-05-26 13:12, hash: `bf53956914` Worked: -- **Short description of the error** Certain operators (relying on context region) crash when called with `INVOKE_AREA` / `EXEC_AREA` **Steps to reproduce** execute this in blenders python console ```python bpy.ops.console.insert("INVOKE_AREA", text="crash") ``` So the reason for the crash is that an operator is invoked with INVOKE_AREA here (it does not crash with INVOKE_DEFAULT or any other Execution Context -- except for EXEC_AREA, same thing applies for that one, see below) If `INVOKE_AREA` or `EXEC_AREA` is used, the region gets removed from context, see ``` case WM_OP_EXEC_AREA: case WM_OP_INVOKE_AREA: { /* Remove region from context. */ ARegion *region = CTX_wm_region(C); CTX_wm_region_set(C, nullptr); retval = wm_operator_invoke(C, ot, event, properties, reports, poll_only, true); CTX_wm_region_set(C, region); ``` Operators relying on / using region (e.g. via CTX_wm_region) can easily crash then. Of course we could guard against this with a simple check (and this is done in a couple of places), not sure though if this is the smartest thing to do -- since there are many, many operators that would need the extra treatment...) **Original report** This script is use to check the active material, it can be run correct in the main window, but not popup window(change the pref window to node editor) ``` import bpy bpy.ops.screen.userpref_show("INVOKE_AREA") area = bpy.context.window_manager.windows[-1].screen.areas[0] area.type = 'NODE_EDITOR' flip_header = True area.ui_type = 'ShaderNodeTree' area.spaces[0].node_tree = bpy.data.materials['Material'].node_tree for region in area.regions: if region.type == 'HEADER': with bpy.context.temp_override(area=area, region=region): if flip_header: bpy.ops.screen.region_flip('INVOKE_DEFAULT') # this line will not if region.type == 'WINDOW': with bpy.context.temp_override(area=area, region=region): bpy.ops.node.view_all("INVOKE_AREA") # this line will report context error ``` **Exact steps for others to reproduce the error** - Open .blend file - Execute script [#98491.blend](https://archive.blender.org/developer/F13125231/T98491.blend)

yonghao lv commented

2022-05-30 12:00:21 +02:00

Added subscriber: @1029910278

Philipp Oeser commented

2022-05-30 13:36:03 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-05-30 13:36:03 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Philipp Oeser commented

2022-05-30 13:36:03 +02:00

I am getting the wrong context, but no crash.

To avoid the context error, I think you need to set the nodetree explicitly?

area.type = 'NODE_EDITOR'
flip_header = True
area.ui_type = 'ShaderNodeTree'
area.spaces[0].node_tree = bpy.data.materials['Material'].node_tree

So:

does setting the node_tree work for you?
do you have an idea on how to trigger the crash (intead of the error)
do you get crash logs? https://docs.blender.org/manual/en/3.3/troubleshooting/crash.html#windows

I am getting the wrong context, but no crash. To avoid the context error, I think you need to set the nodetree explicitly? ``` area.type = 'NODE_EDITOR' flip_header = True area.ui_type = 'ShaderNodeTree' area.spaces[0].node_tree = bpy.data.materials['Material'].node_tree ``` So: - does setting the node_tree work for you? - do you have an idea on how to trigger the crash (intead of the error) - do you get crash logs? https://docs.blender.org/manual/en/3.3/troubleshooting/crash.html#windows

yonghao lv commented

2022-05-30 15:04:39 +02:00

This comment was removed by @1029910278

*This comment was removed by @1029910278*

yonghao lv commented

2022-05-30 15:08:10 +02:00

setting the node tree will be directly crash
area.spaces- [x].node_tree = bpy.context.object.active_material.node_tree
test1.crash.txt

previous crash
blender.crash.txt

setting the node tree will be directly crash `area.spaces- [x].node_tree = bpy.context.object.active_material.node_tree` [test1.crash.txt](https://archive.blender.org/developer/F13123049/test1.crash.txt) previous crash [blender.crash.txt](https://archive.blender.org/developer/F13123029/blender.crash.txt)

Philipp Oeser commented

2022-05-30 15:19:09 +02:00

Changed status from 'Needs User Info' to: 'Needs Triage'

Pratik Borhade commented

2022-05-31 20:00:52 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Certain operators (relying on context region) crash when called with INVOKE_AREA / EXEC_AREA #98491

Certain operators (relying on context region) crash when called with `INVOKE_AREA` / `EXEC_AREA` #98491