Regression: Video in node group doesn't play #99932
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#99932
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.76
Blender Version
Broken: version: 3.3.0 Alpha, branch: master, commit date: 2022-07-22 21:12, hash:
82467e5dcf
Worked: 3.1.2
Caused by
f517b3a295
Short description of error
image texture videos don't play while in a node group
Exact steps for others to reproduce the error
It should stop playing at this point.
If there is another image texture using the same video OUTSIDE the group at the same time, the video from the group still works. It will break as soon as the outside image texture is deleted.
Added subscriber: @JoeyC
#100283 was marked as duplicate of this issue
Changed status from 'Needs Triage' to: 'Confirmed'
Added subscriber: @PratikPB2123
Added subscriber: @fclem
Introduced between
8c4bd02b06
-ae2d2c9361
I don't use full builds so can't really bisect. But I suspect one of the Clemet's commit has caused this
cc @fclem (Feel free to unsubscribe if you're not responsible for this issue :) )
Video in node group doesn't playto Regression: Video in node group doesn't playAdded subscriber: @Jeroen-Bakker
Assign to me for bisecting, and making an example file.
Added subscribers: @HooglyBoogly, @JacquesLucke
Issue is that the
iuser->framenr
of theNodeTextureImage
isn't updated when in a node-group. Doesn't seem to be related to eevee/viewport.Most likely to be introduced by D14957
think that the issue is that
update_has_image_animation
assumes that the group nodes are always evaluated before the main shader tree.@JacquesLucke, @HooglyBoogly is it ok to appoint this one to one of you?
I would add a flag if the evaluation is 'up-to-date' but not sure what the definition is.
}
}
if (has_image_animation || BKE_image_user_id_has_animation(id)) {
ID *id_cow = get_cow_id(id);
}
}
if (has_image_animation || BKE_image_user_id_has_animation(id)) {
OperationKey image_animation_key(```
Added subscriber: @Wassily
Added subscriber: @lichtwerk
Did the bisect for completeness and yes, it was caused by
f517b3a295
@JacquesLucke : mind checking once again?
This issue was referenced by
95464a842c
Changed status from 'Confirmed' to: 'Resolved'