blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 747 Projects 19 Wiki Activity

Fix T86476 EEVEE: SSS material with variable radius can produce NaNs 

Simple divide by 0 error. The input radius was assumed to be safe
but is not when the user can scale it arbitrarly.

This also move the division out of the loop.
This commit is contained in:
Clément Foucault 2021-03-13 17:06:07 +01:00
parent 165a2da753
commit 09e77d2c89
Notes: blender-bot 2023-02-14 02:43:21 +01:00 
Referenced by issue #86473, Screen Space Reflections artifacts (most noticable when using half res trace)
Referenced by issue #86476, using sss on a material causes weird white artifacts.
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/draw/engines/eevee/shaders/effect_subsurface_frag.glsl
View File

@ -45,6 +45,8 @@ void main(void)
vec2 scale = vec2(ProjectionMatrix[0][0], ProjectionMatrix[1][1]) * sss_radius / homcoord;
vec2 finalStep = scale * 0.5; /* samples range -1..1 */
float sss_radius_inv = 1.0 / max(1e-8, sss_radius);
/* Center sample */
vec3 accum = sss_irradiance * kernel[0].rgb;
@ -58,7 +60,7 @@ void main(void)
* by Jimenez, eqs. 2 and 9, and D9740.
* Coefficient -2 follows from gaussian_profile() from gpu_material.c and
* from the definition of finalStep. */
float depth_delta = (depth_view - sample_depth) / sss_radius;
float depth_delta = (depth_view - sample_depth) * sss_radius_inv;
float s = exp(-2.0 * sqr(depth_delta));
/* Out of view samples. */
if (any(lessThan(sample_uv, vec2(0.0))) || any(greaterThan(sample_uv, vec2(1.0)))) {