blender
/
blender
135
403
Fork 585
Code Issues 6.3k Pull Requests 760 Projects 19 Wiki Activity

Fix T85963: Combine and separate XYZ nodes don't work on instances 

They were missing the `geometry_set_realize_instances` function used to
make any input instances real for writing.
This commit is contained in:
Hans Goudey 2021-02-24 16:11:21 -06:00
parent 01e13e2c95
commit 17260c9b9a
Notes: blender-bot 2023-02-14 08:33:26 +01:00 
Referenced by issue #86056, Blender not opening
Referenced by issue #85980, Eevee diffuse colour pass goes white before showing result
Referenced by issue #85963, Geometry Nodes: The Attribute Combine XYZ and Separate XYZ nodes don't work on instanced geometry
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source/blender/nodes/geometry/nodes/node_geo_attribute_combine_xyz.cc
View File

@ -121,6 +121,8 @@ static void geo_node_attribute_combine_xyz_exec(GeoNodeExecParams params)
{
GeometrySet geometry_set = params.extract_input<GeometrySet>("Geometry");
geometry_set = geometry_set_realize_instances(geometry_set);
if (geometry_set.has<MeshComponent>()) {
combine_attributes(geometry_set.get_component_for_write<MeshComponent>(), params);
}

2
source/blender/nodes/geometry/nodes/node_geo_attribute_separate_xyz.cc
View File

@ -147,6 +147,8 @@ static void geo_node_attribute_separate_xyz_exec(GeoNodeExecParams params)
{
GeometrySet geometry_set = params.extract_input<GeometrySet>("Geometry");
geometry_set = geometry_set_realize_instances(geometry_set);
if (geometry_set.has<MeshComponent>()) {
separate_attribute(geometry_set.get_component_for_write<MeshComponent>(), params);
}