blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 746 Projects 19 Wiki Activity

Fix T53463: Rotation numerical input shows instable behaviour. 

Inverting a number in radians when user is in degrees gives rather
unexpected results. ;)
This commit is contained in:
Bastien Montagne 2017-12-04 18:40:33 +01:00
parent 40822ae4e9
commit 1802d14394
Notes: blender-bot 2023-02-14 06:20:52 +01:00 
Referenced by issue #53683, 2.79a release
Referenced by issue #53528, Empty thumbnails in filebrowser
Referenced by issue #53490, keyframed Boolean causes CUDA error
Referenced by issue #53463, Rotation numerical imput shows instable behaviour
Referenced by issue #53472, Cycles doesn't render smoke properly with adjusted clipping distances
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
source/blender/editors/util/numinput.c
View File

@ -488,8 +488,9 @@ bool handleNumInput(bContext *C, NumInput *n, const wmEvent *event)
const float fac = (float)BKE_scene_unit_scale(&sce->unit, n->unit_type[idx], 1.0);
/* Make radian default unit when needed. */
if (n->unit_use_radians && n->unit_type[idx] == B_UNIT_ROTATION)
if (n->unit_use_radians && n->unit_type[idx] == B_UNIT_ROTATION) {
default_unit = "r";
}
BLI_strncpy(str_unit_convert, n->str, sizeof(str_unit_convert));
@ -513,7 +514,16 @@ bool handleNumInput(bContext *C, NumInput *n, const wmEvent *event)
n->val[idx] = -n->val[idx];
}
if (n->val_flag[idx] & NUM_INVERSE) {
n->val[idx] = 1.0f / n->val[idx];
val = n->val[idx];
/* If we invert on radians when user is in degrees, you get unexpected results... See T53463. */
if (!n->unit_use_radians && n->unit_type[idx] == B_UNIT_ROTATION) {
val = RAD2DEG(val);
}
val = 1.0 / val;
if (!n->unit_use_radians && n->unit_type[idx] == B_UNIT_ROTATION) {
val = DEG2RAD(val);
}
n->val[idx] = (float)val;
}
if (UNLIKELY(!isfinite(n->val[idx]))) {