blender
/
blender
134
398
Fork 580
Code Issues 6.3k Pull Requests 758 Projects 19 Wiki Activity

Cleanup: Use bool for BMesh creation params 

These boolean options are passed as uint, but they would be
easier to understand if using bool.

Differential Revision: https://developer.blender.org/D14405
This commit is contained in:
Hans Goudey 2022-03-22 09:38:12 -05:00
parent 64cd927519
commit 1c790555a0
Notes: blender-bot 2023-02-14 01:52:41 +01:00 
Referenced by commit 2d7957727c, Fix: Incorrect conversion from C bitfield syntax
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
source/blender/bmesh/intern/bmesh_mesh_convert.h
View File

@ -18,12 +18,12 @@ void BM_mesh_cd_flag_apply(BMesh *bm, char cd_flag);
char BM_mesh_cd_flag_from_bmesh(BMesh *bm);
struct BMeshFromMeshParams {
uint calc_face_normal : 1;
uint calc_vert_normal : 1;
bool calc_face_normal : true;
bool calc_vert_normal : true;
/* add a vertex CD_SHAPE_KEYINDEX layer */
uint add_key_index : 1;
bool add_key_index : true;
/* set vertex coordinates from the shapekey */
uint use_shapekey : 1;
bool use_shapekey : true;
/* define the active shape key (index + 1) */
int active_shapekey;
struct CustomData_MeshMasks cd_mask_extra;
@ -43,7 +43,7 @@ void BM_mesh_bm_from_me(BMesh *bm, const struct Mesh *me, const struct BMeshFrom
struct BMeshToMeshParams {
/** Update object hook indices & vertex parents. */
uint calc_object_remap : 1;
bool calc_object_remap : true;
/**
* This re-assigns shape-key indices. Only do if the BMesh will have continued use
* to update the mesh & shape key in the future.
@ -53,12 +53,12 @@ struct BMeshToMeshParams {
* so a second flush or edit-mode exit doesn't run with indices
* that have become invalid from updating the shape-key, see T71865.
*/
uint update_shapekey_indices : 1;
bool update_shapekey_indices : true;
/**
* Instead of copying the basis shape-key into the #MVert array,
* copy the #BMVert.co directly to #MVert.co (used for reading undo data).
*/
uint active_shapekey_to_mvert : 1;
bool active_shapekey_to_mvert : true;
struct CustomData_MeshMasks cd_mask_extra;
};
/**