blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 746 Projects 19 Wiki Activity

Fix T44027: Normal Edit Mod : Radial from object normals affected by target object scale. 

The way we were getting diff to apply to vcos from target object was just bad!

Also, fixed another related issue - negated scale would be clamped to nearly zero,
now only consider absolute version of size (we do not care about its sign here anyway).

This should be backported to 2.74 (with previous commit too).
This commit is contained in:
Bastien Montagne 2015-03-17 18:14:38 +01:00
parent 6ceb84c217
commit 2ab4489f17
Notes: blender-bot 2023-02-14 09:22:32 +01:00 
Referenced by issue #44027, Normal Edit Mod : Radial from object normals affected by target object scale.
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
source/blender/modifiers/intern/MOD_normal_edit.c
View File

@ -60,7 +60,8 @@ static void generate_vert_coordinates(
/* Get size (i.e. deformation of the spheroid generating normals), either from target object, or own geometry. */
if (ob_center) {
copy_v3_v3(r_size, ob_center->size);
/* Not we are not interested in signs here - they are even troublesome actually, due to security clamping! */
abs_v3_v3(r_size, ob_center->size);
}
else {
minmax_v3v3_v3_array(min_co, max_co, r_cos, num_verts);
@ -80,12 +81,10 @@ static void generate_vert_coordinates(
if (ob_center) {
/* Translate our coordinates so that center of ob_center is at (0, 0, 0). */
float mat[4][4];
/* Get ob_center coordinates in ob local coordinates. */
invert_m4_m4(mat, ob_center->obmat);
mul_m4_m4m4(mat, mat, ob->obmat);
copy_v3_v3(diff, mat[3]);
/* Get ob_center (world) coordinates in ob local coordinates.
* No need to take into accound ob_center's space here, see T44027. */
mul_v3_m4v3(diff, ob->obmat, ob_center->obmat[3]);
negate_v3(diff);
do_diff = true;
}