blender
/
blender
134
402
Fork 585
Code Issues 6.3k Pull Requests 759 Projects 19 Wiki Activity

Fix T97053: on cage GPU subdivision shows subdivided edges as actual 

edges

When wireframe mode is turned on, the subdivision edges not originating
from coarse edges were also drawn as regular edges, which would confuse
users trying to select them. These should not be drawn in edit mode,
only in object mode when optimal display is turned off (matching the CPU
subdivision case).
This commit is contained in:
Kévin Dietrich 2022-04-14 03:04:29 +02:00
parent 8826db8f03
commit 3f305b9ab3
Notes: blender-bot 2023-10-12 12:49:04 +02:00 
Referenced by issue #99715, Regression: Optimal Display can't be turned off in Edit Mode (GPU subdivision)
Referenced by issue #97053, GPU subdivision: On cage option displaying new subdivided edges like actual edges
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/draw/intern/draw_cache_impl_subdivision.cc
View File

@ -1942,7 +1942,9 @@ static bool draw_subdiv_create_requested_buffers(const Scene *scene,
return false;
}
const bool optimal_display = (smd->flags & eSubsurfModifierFlag_ControlEdges);
/* Edges which do not come from coarse edges should not be drawn in edit mode, only in object
* mode when optimal display in turned off. */
const bool optimal_display = (smd->flags & eSubsurfModifierFlag_ControlEdges) || is_editmode;
draw_cache->bm = bm;
draw_cache->mesh = mesh_eval;