blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 752 Projects 19 Wiki Activity

Fix T83020: Transform: AutoConstraint being confirmed without releasing the MMB 

The transform modifiers are confirmed by releasing any button.

Thus, the operation can be falsely confirmed if the button that launched
the operation is released after the modifier has been activated.

Previously the events that confirmed the modifiers were hardcoded.

An option to fix this would be to add custom confirmation keyitens for
specific modifiers. But this can be a bit confusing and would make the
modal keymap even bigger.

So the solution here is to skip the button that launched the operation
when confirming the modifier.
This commit is contained in:
Germano Cavalcante 2020-11-26 11:42:13 -03:00
parent 849debe36c
commit 44f5d99cbf
Notes: blender-bot 2023-02-14 05:41:57 +01:00 
Referenced by issue #83216, Potential candidates for corrective releases
Referenced by issue #83177, Industry Compatible keymap: MMB-dragging to transform engages axis-constraining on release
Referenced by issue #83020, 2.91: G+MMB select direction drops before releasing MMB
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
source/blender/editors/transform/transform.c
View File

@ -1203,7 +1203,24 @@ int transformEvent(TransInfo *t, const wmEvent *event)
handled = true;
}
break;
case EVENT_NONE:
case INBETWEEN_MOUSEMOVE:
case INPUTCHANGE:
case WINDEACTIVATE:
case TIMER:
case TIMERJOBS:
case TIMERAUTOSAVE:
case TIMERREPORT:
case TIMERREGION:
case TIMERNOTIFIER:
case TIMERF:
/* Although rare, prevent these events from affecting the state of the modifiers. */
break;
default: {
if (event->type == t->launch_event) {
/* The user can hold the launch button and release it here. */
break;
}
/* Disable modifiers. */
int modifiers = t->modifiers;
modifiers &= ~MOD_CONSTRAINT_SELECT;