blender
/
blender
134
399
Fork 581
Code Issues 6.3k Pull Requests 754 Projects 19 Wiki Activity

Fix T86768, bevel doesn't loop slide sometimes. 

Six years ago, Bug T44961 about unwanted spikes had me not do a loop
slide if the angle was too extreme, to avoid unwanted spikes.
The current bug showed that that angle was much too big, and limited
desired behavior in many cases. Changing the angle from 0.25 radians
to 0.0001 radians (about 0.006 degrees) still fixes the original bug
and seems very unlikely to be limiting desired behavior now.
This commit is contained in:
Howard Trickey 2021-07-25 15:14:37 -04:00
parent 0aad8100ae
commit 4886ed2863
Notes: blender-bot 2023-02-14 10:35:28 +01:00 
Referenced by issue #102532, Regression: Bevel modifier spikes with the Loop Slide option
Referenced by issue #95335, Regression: Bevel operator Loop Slide overshoot
Referenced by issue #86768, bevel loop slide failures
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/bmesh/tools/bmesh_bevel.c
View File

@ -1495,8 +1495,9 @@ static void offset_meet(BevelParams *bp,
}
}
/* Chosen so 1/sin(BEVEL_GOOD_ANGLE) is about 4, giving that expansion factor to bevel width. */
#define BEVEL_GOOD_ANGLE 0.25f
/* This was changed from 0.25f to fix bug T86768. Original bug T44961 remainx fixed with this
* value. */
#define BEVEL_GOOD_ANGLE 0.0001f
/**
* Calculate the meeting point between e1 and e2 (one of which should have zero offsets),