blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 748 Projects 19 Wiki Activity

Fix T52176: Bevel doesn't correctly work with default empty Vgroup. 

`defvert_array_find_weight_safe()` was confusing 'invalid vgroup' and
'valid but totally empty vgroup' cases.

Note that this also affected at least ShrinkWrap and SimpleDeform
modifiers.
This commit is contained in:
Bastien Montagne 2017-07-26 16:23:24 +02:00
parent edc6bec9d6
commit 66e28a2827
Notes: blender-bot 2023-02-14 06:46:19 +01:00 
Referenced by issue #52176, Bevel doesn't correctly work with default empty Vgroup
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
source/blender/blenkernel/intern/deform.c
View File

@ -621,8 +621,17 @@ float defvert_find_weight(const struct MDeformVert *dvert, const int defgroup)
*/
float defvert_array_find_weight_safe(const struct MDeformVert *dvert, const int index, const int defgroup)
{
if (defgroup == -1 || dvert == NULL)
/* Invalid defgroup index means the vgroup selected is invalid, does not exist, in that case it is OK to return 1.0
* (i.e. maximum weight, as if no vgroup was selected).
* But in case of valid defgroup and NULL dvert data pointer, it means that vgroup **is** valid,
* and just totally empty, so we shall return '0.0' value then!
*/
if (defgroup == -1) {
return 1.0f;
}
else if (dvert == NULL) {
return 0.0f;
}
return defvert_find_weight(dvert + index, defgroup);
}