blender
/
blender
130
398
Fork 573
Code Issues 6.2k Pull Requests 746 Projects 19 Wiki Activity

Fix T42593: Rigify crash when I press "Generate" - corrupted IDGroup's listbase of children 

Nothing related to rigify actually, recent hack in py handling of IDProp (rB3346ab03)
was breaking integrity of IDGroup's listbase of children IDProps...

Took me hours to nail this down, should have bisected for once. :/
This commit is contained in:
Bastien Montagne 2014-11-14 16:38:11 +01:00
parent 5a893d09d2
commit 6e17fb8fe3
Notes: blender-bot 2023-02-14 20:02:00 +01:00 
Referenced by issue blender/blender-addons#42593, Rigify crash when when I press "Generate"
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/python/generic/idprop_py_api.c
View File

@ -519,6 +519,10 @@ bool BPy_IDProperty_Map_ValidateAndCreate(PyObject *name_obj, IDProperty *group,
(prop_exist->type == prop->type) &&
(prop_exist->subtype == prop->subtype))
{
/* Preserve prev/next links!!! See T42593. */
prop->prev = prop_exist->prev;
prop->next = prop_exist->next;
IDP_FreeProperty(prop_exist);
*prop_exist = *prop;
MEM_freeN(prop);