blender
/
blender
134
399
Fork 582
Code Issues 6.3k Pull Requests 755 Projects 19 Wiki Activity

Fix T90595: some VSE strip properties do not identify strip name in anim 

channel names

Working with multiple strips keyframes was unneccessarily difficult in
Animation Editors (since some anim channels could not be distinguished).

Namely `Crop` and `Transform` are nested structs (nested under
`Sequence`), so these were just displaying the raw struct name.
Also strip modifiers did not have their strip name in their channel
names. Now include the strip name for these.

before
{F10277439}

after
{F10277441}

Maniphest Tasks: T90595

Differential Revision: https://developer.blender.org/D12193
This commit is contained in:
Philipp Oeser 2021-08-11 13:53:19 +02:00
parent 0b3c7544b5
commit 77744b581d
Notes: blender-bot 2023-02-14 06:17:14 +01:00 
Referenced by commit 8b516d8712, Include node name for socket animation channel UI
Referenced by issue #90595, VSE/Graph: Certain animated properties of visual strips do not identify strip name in graph editor
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
source/blender/editors/animation/anim_ipo_utils.c
View File

@ -134,6 +134,28 @@ int getname_anim_fcurve(char *name, ID *id, FCurve *fcu)
else {
structname = RNA_struct_ui_name(ptr.type);
}
/* For the VSE, a strip's 'Transform' or 'Crop' is a nested (under Sequence) struct, but
* displaying the struct name alone is no meaningful information (and also cannot be
* filtered well), same for modifiers. So display strip name alongside as well. */
if (GS(ptr.owner_id->name) == ID_SCE) {
if (BLI_str_startswith(fcu->rna_path, "sequence_editor.sequences_all[\"")) {
if (strstr(fcu->rna_path, ".transform.") || strstr(fcu->rna_path, ".crop.") ||
strstr(fcu->rna_path, ".modifiers[")) {
char *stripname = BLI_str_quoted_substrN(fcu->rna_path, "sequences_all[");
const char *structname_all = BLI_sprintfN(
"%s : %s", stripname ? stripname : "", structname);
if (free_structname) {
MEM_freeN((void *)structname);
}
if (stripname) {
MEM_freeN(stripname);
}
structname = structname_all;
free_structname = 1;
}
}
}
}
/* Property Name is straightforward */