blender
/
blender
136
404
Fork 586
Code Issues 6.2k Pull Requests 753 Projects 19 Wiki Activity

Fix T71019: Disappearing file thumbnails & crash on area split 

When opening the file browser as regular editor, the ID filter flags
as stored in FileSelectParams were not set explicitly, so they were 0.
Since 9100982e80, the value actually passed to the filtering could
differ from that, causing the file list cache to be constantly updated
on every redraw.

Caused by 9100982e80.

Note that this "accidentially" got fixed in master with b546263642,
which is why the issue only showed up in the release branch from that
point.
This commit is contained in:
Julian Eisel 2019-10-28 19:22:44 +01:00
parent 43a8fdb6ad
commit 7c1fbe24ca
Notes: blender-bot 2023-02-14 03:46:57 +01:00 
Referenced by issue #71019, Thumbnails in Filebrowser disappearing, Splitting the Filebrowser Area Window chrashes Blender
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/editors/space_file/filesel.c
View File

@ -107,6 +107,7 @@ short ED_fileselect_set_params(SpaceFile *sfile)
sfile->params->thumbnail_size = U_default.file_space_data.thumbnail_size;
/* Show size column by default. */
sfile->params->details_flags = U_default.file_space_data.details_flags;
sfile->params->filter_id = FILTER_ID_ALL;
}
params = sfile->params;
@ -246,9 +247,6 @@ short ED_fileselect_set_params(SpaceFile *sfile)
}
}
/* For now, always init filterid to 'all true' */
params->filter_id = FILTER_ID_ALL;
if (U.uiflag & USER_HIDE_DOT) {
params->flag |= FILE_HIDE_DOT;
}