blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 752 Projects 19 Wiki Activity

Fix T45620: Coplanar faces w/ flipped normals not selected

This commit is contained in:
Campbell Barton 2015-08-03 20:44:41 +10:00
parent 1b8afac652
commit c2c4e02d41
Notes: blender-bot 2023-02-14 10:37:50 +01:00 
Referenced by issue #45620, Coplanar faces, but with inverted Normal, are not considered coplanar in Blender.
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
source/blender/bmesh/operators/bmo_similar.c
View File

@ -207,16 +207,23 @@ void bmo_similar_faces_exec(BMesh *bm, BMOperator *op)
break;
case SIMFACE_COPLANAR:
{
float sign = 1.0f;
angle = angle_normalized_v3v3(fs->no, fm->no); /* angle -> 0 */
/* allow for normal pointing in either direction (just check the plane) */
if (angle > (float)M_PI * 0.5f) {
angle = (float)M_PI - angle;
sign = -1.0f;
}
if (angle <= thresh_radians) { /* and dot product difference -> 0 */
delta_fl = f_ext[i].d - f_ext[indices[idx]].d;
delta_fl = f_ext[i].d - (f_ext[indices[idx]].d * sign);
if (bm_sel_similar_cmp_fl(delta_fl, thresh, compare)) {
BMO_elem_flag_enable(bm, fm, FACE_MARK);
cont = false;
}
}
break;
}
case SIMFACE_AREA:
delta_fl = f_ext[i].area - f_ext[indices[idx]].area;
if (bm_sel_similar_cmp_fl(delta_fl, thresh, compare)) {