blender
/
blender
132
398
Fork 577
Code Issues 6.2k Pull Requests 744 Projects 19 Wiki Activity

Fix intersect_line_plane bug causing crash on Motion trail and other 

similar potential bugs in mathutils_geometry

marking no_flip as TODO
This commit is contained in:
Benoit Bolsee 2013-12-11 10:31:58 +01:00 committed by Dalai Felinto
parent 1f05d71e24
commit c35fb528c5
Notes: blender-bot 2023-02-14 20:12:04 +01:00 
Referenced by issue blender/blender-addons#37767, Motion Trail addon segfaults on debug builds
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
source/blender/python/mathutils/mathutils_geometry.c
View File

@ -576,12 +576,14 @@ static PyObject *M_Geometry_intersect_line_plane(PyObject *UNUSED(self), PyObjec
{
VectorObject *line_a, *line_b, *plane_co, *plane_no;
float isect[3];
int no_flip = false;
if (!PyArg_ParseTuple(args, "O!O!O!O!|i:intersect_line_plane",
&vector_Type, &line_a,
&vector_Type, &line_b,
&vector_Type, &plane_co,
&vector_Type, &plane_no))
&vector_Type, &plane_no,
&no_flip))
{
return NULL;
}
@ -601,6 +603,7 @@ static PyObject *M_Geometry_intersect_line_plane(PyObject *UNUSED(self), PyObjec
return NULL;
}
/* TODO: implements no_flip */
if (isect_line_plane_v3(isect, line_a->vec, line_b->vec, plane_co->vec, plane_no->vec) == 1) {
return Vector_CreatePyObject(isect, 3, Py_NEW, NULL);
}
@ -633,7 +636,7 @@ static PyObject *M_Geometry_intersect_plane_plane(PyObject *UNUSED(self), PyObje
float isect_co[3];
float isect_no[3];
if (!PyArg_ParseTuple(args, "O!O!O!O!|i:intersect_plane_plane",
if (!PyArg_ParseTuple(args, "O!O!O!O!:intersect_plane_plane",
&vector_Type, &plane_a_co,
&vector_Type, &plane_a_no,
&vector_Type, &plane_b_co,