blender
/
blender
136
403
Fork 586
Code Issues 6.2k Pull Requests 760 Projects 19 Wiki Activity

Fix T83064: Missing tooltips, caused by string property search button 

When a searchbox-button for string properties (e.g. to reference a vertex
group) was created, and a value was set, the tooltip timer would constantly get
cancelled.
That was because the code to validate the current value
(`ui_but_search_refresh()` - early exists for non-string properties) would call
a helper function to update the search results (`ui_searchbox_update_fn()`),
which always reset tooltips. Resetting them in the helper makes sense, for as
long as the searchbox is open. But while it's not, and we just validate the
current value, it shouldn't do this.

This was also noticable in the output settings of dynamic paint, and probably a
number of other cases (especially with script UIs which tend to use string
properties more often).

Likely caused by de53c039ad.
This commit is contained in:
Julian Eisel 2021-02-02 13:41:32 +01:00
parent f3a2434bb6
commit e3c8363ce0
Notes: blender-bot 2023-02-14 07:40:56 +01:00 
Referenced by issue #83064, Tooltips don't appear when hovering cursor in middle of number field in Physics Properties
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
source/blender/editors/interface/interface_region_search.c
View File

@ -463,8 +463,11 @@ static void ui_searchbox_update_fn(bContext *C,
const char *str,
uiSearchItems *items)
{
wmWindow *win = CTX_wm_window(C);
WM_tooltip_clear(C, win);
/* While the button is in text editing mode (searchbox open), remove tooltips on every update. */
if (search_but->but.editstr) {
wmWindow *win = CTX_wm_window(C);
WM_tooltip_clear(C, win);
}
search_but->items_update_fn(C, search_but->arg, str, items);
}