blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 749 Projects 19 Wiki Activity

Fix T74626: Wrong Face Sets overlay rendering in smooth shading 

The face set color variable needs to be declared inside of the loop in
order to reset it per iteration.

Reviewed By: jbakker

Maniphest Tasks: T74626

Differential Revision: https://developer.blender.org/D7096
This commit is contained in:
Pablo Dobarro 2020-03-10 18:33:50 +01:00
parent 7941ea02f8
commit e4077ea69d
Notes: blender-bot 2023-02-14 02:13:08 +01:00 
Referenced by issue #74626, Remeshing with Smooth Normals causes Face Sets unusual behaviour
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source/blender/gpu/intern/gpu_buffers.c
View File

@ -266,8 +266,8 @@ void GPU_pbvh_mesh_buffers_update(GPU_PBVH_Buffers *buffers,
}
/* Face Sets. */
uchar face_set_color[4] = {UCHAR_MAX, UCHAR_MAX, UCHAR_MAX, UCHAR_MAX};
for (uint i = 0; i < buffers->face_indices_len; i++) {
uchar face_set_color[4] = {UCHAR_MAX, UCHAR_MAX, UCHAR_MAX, UCHAR_MAX};
if (show_face_sets) {
const MLoopTri *lt = &buffers->looptri[buffers->face_indices[i]];
const int fset = abs(sculpt_face_sets[lt->poly]);