blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 745 Projects 19 Wiki Activity

Cleanup: unset 'FILE_ENTRY_PREVIEW_LOADING' at the end 

Although this function only runs on the main thread, it seems safer to
clear the flag only after setting the result.
This commit is contained in:
Germano Cavalcante 2021-11-20 10:34:29 -03:00
parent 59ffe1c5b1
commit e949ac0bfc
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source/blender/editors/space_file/filelist.c
View File

@ -2661,7 +2661,6 @@ bool filelist_cache_previews_update(FileList *filelist)
// printf("%s: %d - %s - %p\n", __func__, preview->index, preview->path, preview->img);
if (entry) {
entry->flags &= ~FILE_ENTRY_PREVIEW_LOADING;
if (preview->icon_id) {
/* The FILE_ENTRY_PREVIEW_LOADING flag should have prevented any other asynchronous
* process from trying to generate the same preview icon. */
@ -2678,6 +2677,7 @@ bool filelist_cache_previews_update(FileList *filelist)
* preview will be retried quite often anyway. */
entry->flags |= FILE_ENTRY_INVALID_PREVIEW;
}
entry->flags &= ~FILE_ENTRY_PREVIEW_LOADING;
}
else {
BKE_icon_delete(preview->icon_id);