Page MenuHome

Particle Info node support for GLSL mode and the internal render.
ClosedPublic

Authored by Alexander Romanov (a.romanov) on May 20 2015, 2:42 PM.

Details

Diff Detail

Repository
rB Blender

Event Timeline

Pretty nice! At some point we should separate material variable initialization from object variable initialization. This will help us passing objects and duplis around like that, but this can always be done later as a cleanup. From quick glance patch looks OK, will take a more in depth look before merging, right after release.

Alexander Romanov (a.romanov) updated this revision to Diff 4270.
  • BGE player build fix

There are some changes needed before further review is done. The patch can be greatly simplified by not passing DupliObjects around.

source/blender/editors/space_view3d/drawmesh.c
1080 ↗(On Diff #4270)

Passing the dupliobject around is quite ugly.

I would add functions like GPU_begin_dupliobject / GPU_end_dupliobject that set/unset the global material dupli object around the call where the dupli is drawn.

source/blender/editors/space_view3d/view3d_draw.c
2178

This will fail. Display list will get called with the options used at compilation time so if particle attributes change, this won't be reflected on the instance. Also lists are not used for what you want (GLSL). Check code above to see why (use_displist disabled in that case)

2194

Due to GLSL (check above), lists are never used. This is the place where you can add the GPU_begin_dupliobject / GPU_end_dupliobject calls mentioned above.

source/blender/render/intern/source/shadeinput.c
1325

No need for this, shaderinput.c has access to R, check

extern struct Render R;

Antony Riakiotakis (psy-fi) requested changes to this revision.
This revision now requires changes to proceed.Jul 13 2015, 3:21 PM
Alexander Romanov (a.romanov) removed rB Blender as the repository for this revision.
Alexander Romanov (a.romanov) updated this revision to Diff 4642.

Fixed dupliobject passing and other inaccuracies

Alexander Romanov (a.romanov) updated this revision to Diff 4653.

Fill particle info parameters of shader input in separate function

This revision was automatically updated to reflect the committed changes.