Page MenuHome

Cycles: Add support for float4 textures on OpenCL.
ClosedPublic

Authored by Thomas Dinges (dingto) on May 9 2016, 5:06 PM.

Details

Summary

Title says it all, this adds OpenCL float4 texture support.

There is a bug in the code still, I get a "Out of ressources error" on nvidia hardware here, not sure whats wrong yet.
Will investigate further, but maybe someone else has an idea. :)

Diff Detail

Repository
rB Blender

Event Timeline

Thomas Dinges (dingto) retitled this revision from to Cycles: Add support for float4 textures on OpenCL..
Thomas Dinges (dingto) added a reviewer: Cycles.
Thomas Dinges (dingto) updated this object.
Brecht Van Lommel (brecht) requested changes to this revision.May 10 2016, 1:32 AM

I can't see the bug that would cause that error, but some comments.

intern/cycles/kernel/svm/svm_image.h
68–71

This could be a single info array, no if/else needed? Since the ids don't overlap.

intern/cycles/render/image.cpp
802–804

I would try to deduplicate the code for different types more in this function.

919–924

This is missing code for floats.

This revision now requires changes to proceed.May 10 2016, 1:32 AM
Thomas Dinges (dingto) edited edge metadata.
  • Adress review comments. (Well, code can still be de-duplicated a bit, but I first have to check on this more carefully, with e.g. templating.) Can be done later too.
  • Fixed the bug, the info texture wasn't large enough, only contained the amount of textures available, which was good enough for byte4 only, but now we need the entire range.
Thomas Dinges (dingto) edited edge metadata.
  • Whitespace
This revision was automatically updated to reflect the committed changes.