Page MenuHome

Network renderer: simple fix for T43966 - In large projects the default set socket.timeout is to low
ClosedPublic

Authored by Gottfried Hofmann (gottfried) on Sep 5 2016, 4:48 PM.

Details

Summary

This simple change fixes the problem from T43966 (referenced in T45097) without hacking socket.py.

The problem was, that the default timeout was set to a meager 5 seconds, way too low for bigger file. The new default of 50 seconds should be a good fix for 2.78.

For 2.8 I would suggest to expose the timeout as a setting for the user in a first step.
In a second step I would re-write as much of the connection code in the addon as possible using a modern lib like request.

Diff Detail

Event Timeline

Gottfried Hofmann (gottfried) retitled this revision from to Network renderer: simple fix for T43966 - In large projects the default set socket.timeout is to low.
Gottfried Hofmann (gottfried) updated this object.
Gottfried Hofmann (gottfried) set the repository for this revision to rBA Blender Add-ons.
Bastien Montagne (mont29) edited edge metadata.

LGTM, will commit, thanks.

This revision is now accepted and ready to land.Sep 5 2016, 4:52 PM