Page MenuHome

Remove unused vector icons
ClosedPublic

Authored by Martijn Berger (juicyfruit) on Nov 15 2016, 10:49 PM.

Details

Summary

it seems to me the icons are unused:

  • VICO_VIEW3D_VEC
  • VICO_EDIT_VEC
  • VICO_EDITMODE_VEC_DEHLT
  • VICO_EDITMODE_VEC_HLT
  • VICO_DISCLOSURE_TRI_RIGHT_VEC
  • VICO_DISCLOSURE_TRI_DOWN_VEC
  • VICO_MOVE_UP_VEC
  • VICO_MOVE_DOWN_VEC
  • VICO_X_VEC

Since their code contains immediate mode GL calls and they seem to be unused i thought we could remove them.

Diff Detail

Repository
rB Blender

Event Timeline

Martijn Berger (juicyfruit) retitled this revision from to Remove unused vector icons.
Martijn Berger (juicyfruit) updated this object.

Good catch! I like the idea of removal, eager to get @Bastien Montagne (mont29)'s feedback.

Bastien Montagne (mont29) edited edge metadata.

That seem to be very old code, so see no problem to remove it if it’s not used anymore. :)

This revision is now accepted and ready to land.Nov 16 2016, 9:40 AM
This revision was automatically updated to reflect the committed changes.

This change affects three add-ons:

  1. Dynamic Context Menu (space_view3d_spacebar_menu.py) uses X_VEC and EDIT_VEC
  2. Dynamic Toolshelf Menu (from Contrib - space_view3d_toolshelf_menu.py) uses EDIT_VEC
  3. Development: Icons (development_icon_get.py) - there are empty spaces with the removed icons (clicking will still copy their name to the clipboard)

In the last one the code in the function create_icon_list_all():

icons = bpy.types.UILayout.bl_rna.functions['prop'].parameters['icon'].\
       enum_items.keys()

still returns the removed icons.

While the first two add-ons can be adapted to use different icons I'm not sure what is the problem with the last one.