Allow HDR picking from Compositor background
ClosedPublic

Authored by Stefan Werner (swerner) on Fri, Apr 7, 10:15 PM.

Details

Summary

It appears to me that the STREQ comparison in ED_space_node_color_sample() should be negated - it is supposed to early exit when the SpaceNode it not in the compositor tree, not when it is. Also, ED_node_is_compositor() is a descriptive method that does the same as the explicit STREQ.

Diff Detail

Repository
rB Blender

While I'm at it, shouldn't we also replace the various STREQ(snode->tree_idname, ...) calls in node_group.c with the ED_node_is_*() calls for improved readability?

Fix looks good to me.

Changing node_group.c as well sounds good to me.

This revision is now accepted and ready to land.Fri, Apr 14, 4:06 PM