temp diff to reduce recompiles in split kernel
Needs RevisionPublic
Actions

Authored by mathieu menuet (bliblubli) on Dec 3 2017, 8:46 AM.

Details

Reviewers

Summary

it's a wip, not meant for review yet, but last time I uploaded a build with just a paste, I got problems, so here it is, the full diff of my patched build.

The point of this patch is to reduce kernel recompiles when using OpenCL split kernel, while keeping good performance (actually, performance with this patch are higher than with master)

Diff Detail

Repository: rB Blender

mathieu menuet (bliblubli) created this revision.Dec 3 2017, 8:46 AM

mathieu menuet (bliblubli) edited the summary of this revision. (Show Details)Dec 3 2017, 2:25 PM

What is the point of this patch review? If it's not meant for review, at least mark it as "Changes Planned".

But in any case, explaining what exactly this patch does and changes is an essential practice to present your work.

This revision now requires changes to proceed.Dec 6 2017, 2:45 PM

added description. I also don't see the point to do something like that, but @Ton Roosendaal (ton) and @Campbell Barton (campbellbarton) asked me to upload diffs instead of paste last time, so I do it. Otherwise, I would just upload builds with a paste until the patch is stable and well tested by users.

Revision Contents

		Path
M		CMakeLists.txt (2 lines)
M		build_files/cmake/config/blender_release.cmake (2 lines)
M		intern/cycles/blender/addon/properties.py (51 lines)
M		intern/cycles/blender/addon/ui.py (19 lines)
M		intern/cycles/blender/addon/version_update.py (30 lines)
M		intern/cycles/blender/blender_session.cpp (1 line)
M		intern/cycles/blender/blender_sync.cpp (23 lines)
M		intern/cycles/device/device.h (24 lines)
M		intern/cycles/device/device.cpp (22 lines)
M		intern/cycles/device/opencl/opencl_split.cpp (56 lines)
M		intern/cycles/kernel/CMakeLists.txt (2 lines)
M		intern/cycles/kernel/kernel_types.h (26 lines)
M		intern/cycles/kernel/kernels/opencl/kernel_buffer_update.cl (13 lines)
M		intern/cycles/kernel/kernels/opencl/kernel_direct_lighting.cl (13 lines)
M		intern/cycles/kernel/kernels/opencl/kernel_do_volume.cl (10 lines)
M		intern/cycles/kernel/kernels/opencl/kernel_enqueue_inactive.cl (13 lines)
M		intern/cycles/kernel/kernels/opencl/kernel_holdout_emission_blurring_pathtermination_ao.cl (15 lines)
M		intern/cycles/kernel/kernels/opencl/kernel_indirect_background.cl (10 lines)
M		intern/cycles/kernel/kernels/opencl/kernel_indirect_subsurface.cl (10 lines)
M		intern/cycles/kernel/kernels/opencl/kernel_lamp_emission.cl (10 lines)
M		intern/cycles/kernel/kernels/opencl/kernel_next_iteration_setup.cl (13 lines)
M		intern/cycles/kernel/kernels/opencl/kernel_path_init.cl (10 lines)
M		intern/cycles/kernel/kernels/opencl/kernel_queue_enqueue.cl (13 lines)
M		intern/cycles/kernel/kernels/opencl/kernel_scene_intersect.cl (10 lines)
M		intern/cycles/kernel/kernels/opencl/kernel_shader_eval.cl (10 lines)
M		intern/cycles/kernel/kernels/opencl/kernel_shader_setup.cl (13 lines)
M		intern/cycles/kernel/kernels/opencl/kernel_shader_sort.cl (13 lines)
M		intern/cycles/kernel/kernels/opencl/kernel_shadow_blocked_ao.cl (10 lines)
M		intern/cycles/kernel/kernels/opencl/kernel_shadow_blocked_dl.cl (10 lines)
D	M	intern/cycles/kernel/kernels/opencl/kernel_split_function.h (65 lines)
M		intern/cycles/kernel/kernels/opencl/kernel_subsurface_scatter.cl (10 lines)
M		intern/cycles/kernel/svm/svm.h (56 lines)
M		intern/cycles/kernel/svm/svm_types.h (8 lines)
M		intern/cycles/render/graph.h (2 lines)
M		intern/cycles/render/nodes.h (91 lines)
M		intern/cycles/render/shader.cpp (6 lines)
M		make.bat (4 lines)
M		source/blender/blenkernel/BKE_blender_version.h (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	9637			Dec 3 2017, 8:44 AM	★	★

temp diff to reduce recompiles in split kernelNeeds RevisionPublicActions

Details

Diff Detail

Revision Contents

Diff 9637

CMakeLists.txt

build_files/cmake/config/blender_release.cmake

intern/cycles/blender/addon/properties.py

intern/cycles/blender/addon/ui.py

intern/cycles/blender/addon/version_update.py

intern/cycles/blender/blender_session.cpp

intern/cycles/blender/blender_sync.cpp

intern/cycles/device/device.h

intern/cycles/device/device.cpp

intern/cycles/device/opencl/opencl_split.cpp

intern/cycles/kernel/CMakeLists.txt

intern/cycles/kernel/kernel_types.h

intern/cycles/kernel/kernels/opencl/kernel_buffer_update.cl

intern/cycles/kernel/kernels/opencl/kernel_direct_lighting.cl

intern/cycles/kernel/kernels/opencl/kernel_do_volume.cl

intern/cycles/kernel/kernels/opencl/kernel_enqueue_inactive.cl

intern/cycles/kernel/kernels/opencl/kernel_holdout_emission_blurring_pathtermination_ao.cl

intern/cycles/kernel/kernels/opencl/kernel_indirect_background.cl

intern/cycles/kernel/kernels/opencl/kernel_indirect_subsurface.cl

intern/cycles/kernel/kernels/opencl/kernel_lamp_emission.cl

intern/cycles/kernel/kernels/opencl/kernel_next_iteration_setup.cl

intern/cycles/kernel/kernels/opencl/kernel_path_init.cl

intern/cycles/kernel/kernels/opencl/kernel_queue_enqueue.cl

intern/cycles/kernel/kernels/opencl/kernel_scene_intersect.cl

intern/cycles/kernel/kernels/opencl/kernel_shader_eval.cl

intern/cycles/kernel/kernels/opencl/kernel_shader_setup.cl

intern/cycles/kernel/kernels/opencl/kernel_shader_sort.cl

intern/cycles/kernel/kernels/opencl/kernel_shadow_blocked_ao.cl

intern/cycles/kernel/kernels/opencl/kernel_shadow_blocked_dl.cl

intern/cycles/kernel/kernels/opencl/kernel_split_function.h

intern/cycles/kernel/kernels/opencl/kernel_subsurface_scatter.cl

intern/cycles/kernel/svm/svm.h

intern/cycles/kernel/svm/svm_types.h

intern/cycles/render/graph.h

intern/cycles/render/nodes.h

intern/cycles/render/shader.cpp

make.bat

source/blender/blenkernel/BKE_blender_version.h

temp diff to reduce recompiles in split kernel
Needs RevisionPublic
Actions