Fix Minor Typo
ClosedPublic

Authored by John (personalcomputer) on Jun 12 2018, 8:26 AM.

Details

Summary

See https://developer.blender.org/T55448 for details on the typo.

This is a really small issue, but fixing it is an opportunity for me to learn Blender's build process + contribution process + phabricator so I am able to make more substantial bugfixes in the future.

Diff Detail

Repository
rB Blender
John (personalcomputer) edited the summary of this revision. (Show Details)Jun 12 2018, 8:35 AM
John (personalcomputer) edited the summary of this revision. (Show Details)Jun 12 2018, 8:44 AM
John (personalcomputer) edited the summary of this revision. (Show Details)

Thanks for the patch! I'll go ahead and commit it.

Two suggestions for future patches:

  • Using the Arcanist tool makes it easier to submit and check out patches.
  • Your patch seems to be against a file in which the tab whitespace was replaced with spaces. This makes applying the patch tricky and probably introduces unwanted whitespace changes into the patch. I guess your editor is configured to automatically change whitespace, please disable that.
This revision is now accepted and ready to land.Jun 12 2018, 10:36 AM
This revision was automatically updated to reflect the committed changes.

Lukas thank you so much for taking the time to review this and provide me with that feedback!

  • I apologize for the tabs+spaces issue. I do note now that my diff represented it as spaces, which is a mistake, the file should be using tabs still. I will disable that conversion to ensure that any spaces/tabs are not accidentally changed again.
  • Thank you for showing me Arcanist, I will check it out for my future patches.

Thanks!