Page MenuHome

Multi object editing - transform snapping
AbandonedPublic

Authored by Alan Troth (Al) on Aug 28 2018, 4:26 AM.

Diff Detail

Repository
rB Blender
Branch
UV_Transform_Snapping (branched from blender2.8)
Build Status
Buildable 1997
Build 1997: arc lint + arc unit

Event Timeline

Dalai Felinto (dfelinto) requested changes to this revision.Aug 31 2018, 4:16 PM

Could you upload a file so I can test this?

@Campbell Barton (campbellbarton) do you know how to test this? (I assume so since you reported the issue in the first place).

source/blender/editors/transform/transform_snap.c
995

You are never freeing objects. It is probably leaking.

This revision now requires changes to proceed.Aug 31 2018, 4:16 PM
  • Fix memory leak.
Alan Troth (Al) planned changes to this revision.Aug 31 2018, 5:40 PM
Alan Troth (Al) marked an inline comment as done.

While creating a test file I found a problem where the UVs snap to coords that aren't UVs. Investigating...

Alan Troth (Al) requested review of this revision.EditedAug 31 2018, 6:31 PM

While creating a test file I found a problem where the UVs snap to coords that aren't UVs. Investigating...

The snap bug exists in 2.79b. The bug isn't a major problem and shows itself as the selection snapping to a non existent uv. If the user doesn't like the new position of the selected uvs then they can keep moving the mouse to get a better position.

The bug is caused because the selected uvs can snap to themselves. It's a two stage process, first the selected uvs snap to a 'legitamate' uv, then they snap to the new position of one of the selected uv's.

I'll make a bug report when reporting is allowed.


On entering:

  • There are two uv unwrapped objects.
  • You're in uv eding mode with two objects selected. Each object has one UV vertex selected.
  • 'Snap during transform' is on, 'UV element to snap' to is set to vertex.

Press 'G' to move the selected UV vertices.

Before the patch - the vertices only snap to one object.
After the patch - the vertices can snap to both objects.

Thank you, committed on rBa1a58c8d0a95005d84484b2db90ce2cbabc73316 with minor code style fixups.