Page MenuHome

Relative Translation in Transform-Node
Needs RevisionPublic

Authored by Rudolf Ortner (rudolf.ortner) on Sep 19 2018, 7:20 PM.

Details

Summary

The transform-node is a combination of all three transform types (translation, rotation and scale).
To make it resolution independent I added the "Relative"-Option as within the Translation-Node.

Diff Detail

Repository
rB Blender

Event Timeline

Rudolf Ortner (rudolf.ortner) created this object with visibility "All Users".

This is a very long outstanding code review, but still think it is useful to have.
If you don't want to work on this patch I can take over.

source/blender/compositor/nodes/COM_TransformNode.cpp
52

Use an enumeration

source/blender/makesrna/intern/rna_nodetree.c
6384

Better use a flag that is more descriptive.

Jeroen Bakker (jbakker) requested changes to this revision.Thu, Nov 14, 10:17 AM
Jeroen Bakker (jbakker) changed the visibility from "All Users" to "Public (No Login Required)".
This revision now requires changes to proceed.Thu, Nov 14, 10:17 AM

This is a very long outstanding code review, but still think it is useful to have.
If you don't want to work on this patch I can take over.

Thanks for reviewing this patch. It has been a long time since i wrote this. But I exactly stuck to the code that is already there in the source code (translate note).
But if you'd wish to, I will take a look at it. I have to read into the source code again, since I am new to Blender development.