Page MenuHome

Misc. typo fixes pt5
ClosedPublic

Authored by luzpaz (luzpaz) on Sep 28 2018, 5:14 AM.

Details

Summary

Found via codespell -q 3 -I ../blender-word-whitelist.txt --skip="./extern,./intern,./doc/license,./tests/gtests,*.diff"
Followup to D3732

Diff Detail

Repository
rB Blender

Event Timeline

@Brecht Van Lommel (brecht) is there any issue with fixing typos for ./release/scripts/addons ?

Fixes for addons are fine.

How many of these are you planning to submit still? It would be easier for me if it was just one big patch. For some patches splitting it up into smaller parts helps, for spelling fixes that's not really the case though.

How many of these are you planning to submit still? It would be easier for me if it was just one big patch. For some patches splitting it up into smaller parts helps, for spelling fixes that's not really the case though.

I see. I can add the rest of the changes to this commit or just submit the last patch after this one? how do you prefer ?

Also please respond to https://developer.blender.org/D3744?large=true#inline-33463

source/blender/blenlib/intern/path_util.c
1528 ↗(On Diff #11987)

it is assumed void or valid ?

You can add the rest of the changes to this commit.

source/blender/blenlib/intern/path_util.c
1528 ↗(On Diff #11987)

valid.

I'm still not used to using phabricator, so I apologize. So a couple if issues:

  1. I rebased the diff over blender2.8 branch again
  2. I added some leftover commits (unfortnately none of them were from the addons because...
  3. my git client is a GUI and there is a bug that wasn't showing me the commits I made in the addons because it was in a submodule. So I'm going to make a patch from within the submodules for the next commit.

Sorry for the confusion

@Brecht Van Lommel (brecht) hi, just checking on this. Anything you need me to do before it gets committed ?

Should I rebase ?

@Brecht Van Lommel (brecht) i rebased the patch locally. I can break it up in to 2 smaller patches, if you want.

I can look at this a bit after the 2.80 release.

The current patch seems to include whitespace changes in intern/elbeem.

All whitespaces removed.

This revision is now accepted and ready to land.Wed, Jul 31, 2:28 PM