Page MenuHome

Cycles & Eevee Material Nodes: Add Multiply function to Vector Math Node
AbandonedPublic

Authored by Charlie Jolly (charlie) on Oct 11 2018, 6:20 PM.

Details

Reviewers
None
Group Reviewers
Cycles
Eevee

Diff Detail

Repository
rB Blender
Branch
blender2.8
Build Status
Buildable 2223
Build 2223: arc lint + arc unit

Event Timeline

I'll leave it up to @Brecht Van Lommel (brecht) to decide if we want this in but if it does make it in, couple of things:

  1. it kinda feels like if we're gonna have multiply, we should probably have divide as well.
  2. I Recently documented the operations this node performs, please update that as well given this is a 2.8 patch, not sure what the best approach is here, @Aaron Carlisle (Blendify) ?
  3. nit picking unrelated to your patch: the magic numbers in the switch in gpu_shader_vect_math could really use some #defines regardless if this patch makes it or not.

I'll leave it up to @Brecht Van Lommel (brecht) to decide if we want this in but if it does make it in, couple of things:

  1. it kinda feels like if we're gonna have multiply, we should probably have divide as well.
  2. I Recently documented the operations this node performs, please update that as well given this is a 2.8 patch, not sure what the best approach is here, @Aaron Carlisle (Blendify) ?
  3. nit picking unrelated to your patch: the magic numbers in the switch in gpu_shader_vect_math could really use some #defines regardless if this patch makes it or not.
  1. Fair point, see what @Brecht Van Lommel (brecht) thinks too but could be separate patch if this is accepted.
  2. No problem, currently I don't have that repository downloaded. Advice helpful here.
  3. Tidier but that looks like a wider issue in general!
  • Merge branch 'blender2.8' of git://git.blender.org/blender into blender2.8
  • Building blocks for Vector Rotate node
  • Merge branch 'blender2.8' of git://git.blender.org/blender into blender2.8
  • More groundwork
  • Merge branch 'blender2.8' of git://git.blender.org/blender into blender2.8
  • First working version
  • clean up

Last commit was wrong patch, reverting!!

Reset patch after arc error

I Recently documented the operations this node performs, please update that as well given this is a 2.8 patch, not sure what the best approach is here, @Aaron Levey (aaron) Carlisle (Blendify) ?

Please create a todo task under T55018 there you can add a patch to be applied later.

Added diff for manual on T55018. If I did this incorrectly apologies in advance!! Maybe I don't have permissions to create a todo.

This patch is no longer required.

See Shading: Add more operators to Vector Math node: https://developer.blender.org/D5523