Page MenuHome

Mantaflow [Part 2]: Added fluid wrapper files
Needs ReviewPublic

Authored by Sebastián Barschkis (sebbas) on Oct 29 2018, 4:47 PM.

Diff Detail

Repository
rB Blender
Branch
mantaWrapper (branched from master)
Build Status
Buildable 3302
Build 3302: arc lint + arc unit

Event Timeline

Added changes from new outflow object allocation setup.

Fix for smoke outflow (walls and outflow objects)

Update manta files after merge with master.

Cleaned up debug out and did some minor refactoring.

Made some comments about style, not sure how strict we want to be there though, but this is in /intern/@Sergey Sharybin (sergey) or @Brecht Van Lommel (brecht) would know better on that aspect I guess (also because this is C++ code).

intern/mantaflow/CMakeLists.txt
57–59

Does it even make any sense to do anything currently is WITH_PYTHON is FALSE?

intern/mantaflow/extern/manta_fluid_API.h
37–45

(… and whole func definitions actually)

Unless am mistaken, this is a public API, right? Then it would be better to have a common prefix, also for the struct name… Something like MantaFluid for the struct, and MANTA_fluid_free() etc. for the functions?

intern/mantaflow/intern/manta_fluid_API.cpp
36–37

Are all those extern "C" declarations really needed? I thought since their declarations in header are enclosed inside an extern "C" {} bloc, that was enough?