Page MenuHome

User Interface: Add button color for indicating that the value differs from the interpolated one
ClosedPublic

Authored by Lukas Stockner (lukasstockner97) on Fri, Nov 16, 3:06 AM.

Details

Summary

One issue that especially newer users often run into is that they accidentally reset changes to the scene by switching frame without setting a keyframe first.

Therefore, this patch adds a new color that is used to draw the button if the current value differs from the one that would be set when switching to this frame.
This works both for existing keyframes as well as for currently interpolated frames.

Unfortunately the flags in but->flag are full, so I had to move the new flag to but->drawflag and pass that to all relevant functions.

I went with orange for the color for now since afaics it fits with the green and yellow that are currently used for keyframe states and since it's somewhat reddish to signify that there might be something to look out for here.

I hope I got the right reviewers, please add/remove yourself/others if I got someone wrong.

Diff Detail

Repository
rB Blender

Event Timeline

This revision is now accepted and ready to land.Thu, Dec 6, 5:18 AM
Brecht Van Lommel (brecht) requested changes to this revision.Thu, Dec 6, 11:57 AM

Looks useful to me, just one thing to fix.

release/datafiles/userdef/userdef_default_theme.c
231–232

This needs to be added to do_versions_theme, to avoid breaking existing user preferences.

This revision now requires changes to proceed.Thu, Dec 6, 11:57 AM
This revision was not accepted when it landed; it landed in state Needs Revision.Sat, Dec 8, 6:07 PM
This revision was automatically updated to reflect the committed changes.