Page MenuHome

Patch for T57974 : Remove background fade and keep them longer
Needs RevisionPublic

Authored by Lucas Boutrot (thornydre) on Nov 25 2018, 12:07 AM.

Details

Summary

Hi,

I gave this one a try, hope this is fine. Now the background stays until the message disappears.

One thing I found out by testing is that the warning color makes the message unreadable :

If you want I can try to change the background color, or the font color ?

Cheers !

Diff Detail

Repository
rB Blender

Event Timeline

I was not sure but I think all this can be removed as well.

Interesting. Yes, the readability is an issue. I guess we should update the theme to fix this issue. @Pablo Vazquez (pablovazquez): Will you look into the theme thing here?

The text just uses the text color from the statusbar. The simplest solution would be to make the info/warning/error colors darker as in the task, and hardcode the text color to be white. Alternatively we could add all of those colors to the theme, but I'm not sure it's worth it.

@Brecht Van Lommel (brecht) If the text color was to be hardcoded to anything I feel like it should be hardcoded to be black, which stands out on more colors that white would.

@William Reynish (billreynish) So should I hardcode the text color for this one ?

Yes, black should be readable against most colors. I'm not se keen on hardcoding colors though - I wonder if there's a theme color we can use here instead. Well, for now a hardcoded black color would be ok - we can replace it with something else if it's a problem.

I can try adding a theme color for the report text color maybe ? But I'll try to find if there is another one available first

Can't we just use these colors if we don't already?

If text is then not readable, we can just update the default theme.

I thought I would see if I could help here since things haven't been active here for a while.

While I think it makes sense to make the text color black for readability, it isn't very consistent with the rest of the UI. Also the icon for the report stays white and looks inconsistent.

Based on the original task it appears that the idea is to use the colors from the Info area, am I correct in thinking that?

I went ahead and changed the colors, and removed some more of the code for fading colors.

See changes here D4197

Brecht Van Lommel (brecht) requested changes to this revision.Jan 23 2019, 3:53 PM
This revision now requires changes to proceed.Jan 23 2019, 3:53 PM