Page MenuHome

Fix T58479: Quick Favorites Lets you add multiple of the same item

Authored by Philipp Oeser (lichtwerk) on Dec 28 2018, 3:00 PM.

Diff Detail

rB Blender

Event Timeline

note that currently the BKE_report does not show [but apparently other places that push directly to CTX_wm_reports(C) dont either -- so this might be an unrelated issue...], could also be left out completely maybe?

Brecht Van Lommel (brecht) requested changes to this revision.Jan 4 2019, 1:30 PM

Can we grey out the add menu item if it's already in the menu? That's nicer than giving an error message when clicking.

This revision now requires changes to proceed.Jan 4 2019, 1:30 PM

how about this: now only shows a single entry:

  • "Add to Quick Favorites" when not already in the list
  • "Remove from Quick Favorites" when already in the list
  • (also use same icon for both entries)
This revision is now accepted and ready to land.Jan 8 2019, 2:41 PM
This revision was automatically updated to reflect the committed changes.