Page MenuHome

Fix T59939: Masks not Animating in Render
Needs ReviewPublic

Authored by Philipp Oeser (lichtwerk) on Sat, Dec 29, 11:17 PM.

Details

Summary

For now this is not part of copy-on-write, and needs extra animation
evaluation.

Diff Detail

Repository
rB Blender
Branch
T59939 (branched from master)
Build Status
Buildable 2684
Build 2684: arc lint + arc unit

Event Timeline

Great! But I think it should be placed inside of BKE_animsys_evaluate_all_animation() to keep it consistent?

This could call BKE_mask_evaluate_all_masks to simplify the code.

The deeper problem is really that it should be creating a depsgraph copy to fully evaluate the scene and everything that is uses, including masks. Hardcoding masks as a special case in BKE_animsys_evaluate_all_animation also seems weak.

Will leave it up to @Sergey Sharybin (sergey) to decide if this kind of workaround is ok, or if we want to solve this better. This is fixing one specific datablock, but there will be a bunch of other things broken too I expect.