Page MenuHome

Fix T60133: texture paint external editing not working
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Jan 16 2019, 11:56 AM.

Diff Detail

Repository
rB Blender
Branch
T60133 (branched from master)
Build Status
Buildable 2770
Build 2770: arc lint + arc unit

Event Timeline

note that for some reason the layout is broken in the menu (as opposed to the popup/panel), maybe @William Reynish (billreynish) knows right away?

@Philipp Oeser (lichtwerk) To do this kind of thing, you need to use a popover. This makes it possible to add essentially a panel inside of a menu.

@William Reynish (billreynish) : bit weird though to have a popover next to the menus?

Yes it’s a bit weird. The whole issue stems from the fact that we don’t have an active viewport in Blender. Not sure what else we can do - alternatively we could do what you suggested, to make it go to a picker or always take the biggest viewport.

... or fix the drawing/layout of a IntArray prop in a menu? (although putting those props in a menu feels strange as well -- and I wouldnt be aware of any menu in blender that does this...)

maybe @Campbell Barton (campbellbarton) has an opinion?
note there were other suggestions in T60133 [tweaking operators to get a 3DView or using a picker...]

The thing is that this feature is somewhat obscure, so making a big popover for it directly in the 3D View seems excessive, and not in line with the relative importance of this feature. We usually only put essential things there, like the mode, the command menus and viewport controls.

It seems nicer to keep it as a panel in the Tool Properties, so it can be tucked away when not in use, and then try and make it work by maybe using the picker method you suggested.

The thing is that this feature is somewhat obscure, so making a big popover for it directly in the 3D View seems excessive, and not in line with the relative importance of this feature. We usually only put essential things there, like the mode, the command menus and viewport controls.
It seems nicer to keep it as a panel in the Tool Properties, so it can be tucked away when not in use, and then try and make it work by maybe using the picker method you suggested.

note that this is currently not only in the Properties Editor Tool Properties panel, but also in the TopBar...

Anyways, I will work on the alternative using a picker then [unless others have objections?]...

Yes, that seems like a nicer overall solution. Sorry for leading you down a strange path here.

Philipp Oeser (lichtwerk) planned changes to this revision.Jan 23 2019, 1:55 PM

Just dropping another thought here before continuing:
Since putting it in a 3D view menu was one of the first intuitions [and only lacked because it wasnt nice to put the screen grab size directly in the menu], we could still do this in a 3D view menu, put the operators there and just show the screen grab size when invoking the operator?

Just make it find the biggest 3D viewport, you can code a function similar to biggest_non_image_area. It's not worth spending much time on this making a picking system, and it will be annoying if you use this feature often.

now just getting the biggest 3DView

Looks good, but please update the error message.

source/blender/editors/sculpt_paint/paint_image_proj.c
5614

This could be a bit more informative: "No 3D viewport found to create image from"

Otherwise sounds a bit like an internal failure.

This revision is now accepted and ready to land.Jan 24 2019, 3:21 PM
This revision was automatically updated to reflect the committed changes.