Page MenuHome

Units for Cycles properties
ClosedPublic

Authored by Robert Guetzkow (rjg) on Jan 25 2019, 11:37 PM.

Diff Detail

Repository
rB Blender

Event Timeline

I've fixed some inconsistent quotation marks in the file as well.

This revision is now accepted and ready to land.Jan 25 2019, 11:53 PM
Brecht Van Lommel (brecht) requested changes to this revision.Jan 26 2019, 12:03 AM
Brecht Van Lommel (brecht) added inline comments.
intern/cycles/blender/addon/properties.py
603

This is a factor relative to the image size, not in pixels.

617

This is a length, not in pixels.

This revision now requires changes to proceed.Jan 26 2019, 12:03 AM

You're right, I was following the remarks of T60824 without checking if the subtype and unit actually matches.

So removing the subtype from camera_cull_margin and make distance_cull_margin a length?

Robert Guetzkow (rjg) updated this revision to Diff 13357.EditedJan 26 2019, 12:31 AM

The camera cull margin is now of subtype FACTOR and the cull distance of unit LENGTH.

Robert Guetzkow (rjg) marked 2 inline comments as done.Jan 26 2019, 9:56 AM

Marked @Brecht Van Lommel (brecht) comments as done.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 26 2019, 3:55 PM
This revision was automatically updated to reflect the committed changes.