Page MenuHome

Remove tweak/drag threshold distinction

Authored by Campbell Barton (campbellbarton) on Feb 8 2019, 3:41 AM.



Currently the preferences have both tweak and drag threshold,
this is confusing because.

  • Values under tweak are used to detect click & double click events.
  • Drag threshold is _not_ used for what most users would consider dragging, instead it's used specifically for dragging buttons.

This exposes 'drag threshold', using the same value for both.

When checking if a button should be dragged, use the same threshold as for clicking or half the UI-unit size, which is more logical if the user sets the threshold very high.

See: T61260, which initiated this topic.

Diff Detail

rB Blender
TEMP-DRAG-THRESH (branched from master)
Build Status
Buildable 2859
Build 2859: arc lint + arc unit

Event Timeline

Add comment explaining reason for clamping drag distance

Only annoying point here is that we now have 'drag threshold' in RNA/UI, but keep 'tweak threshold' in DNA… But I guess it's not really possible to avoid. Besides that, LGTM.

This revision is now accepted and ready to land.Feb 8 2019, 8:48 AM

@Bastien Montagne (mont29), yep, we could even use drag threshold and reset it, I'm not sure if many users adjust this?
(I never found it necessary).

Committed rB43156d830470fbbcd89bc1bd4b1f32d3348ba7a9

We could rename struct member if DNA renaming is supported D4330.