Page MenuHome

Fix VSE color picker
ClosedPublic

Authored by Richard Antalik (ISS) on Feb 23 2019, 3:56 AM.

Details

Summary

Fix VSE color picker mouse coords calculation

Diff Detail

Repository
rB Blender

Event Timeline

Brecht Van Lommel (brecht) requested changes to this revision.Feb 25 2019, 5:42 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/blenkernel/BKE_sequencer.h
243 ↗(On Diff #13810)

This should get a BKE_sequencer prefix since it's now exposed as a public function.

This revision now requires changes to proceed.Feb 25 2019, 5:42 PM
Richard Antalik (ISS) edited the summary of this revision. (Show Details)Mar 16 2019, 12:51 AM
Richard Antalik (ISS) updated this revision to Diff 14208.

I am dividing by scene->r.*sch - should I check for zero?

No need to check for zero, this value is guaranteed to be higher.

This revision is now accepted and ready to land.Mar 18 2019, 12:05 PM
This revision was automatically updated to reflect the committed changes.