Page MenuHome

Fix T62053: Composite rendering more images than needed
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Mar 1 2019, 11:53 AM.

Diff Detail

Repository
rB Blender

Event Timeline

Harbormaster completed remote builds in B3025: Diff 13942.
Brecht Van Lommel (brecht) requested changes to this revision.Mar 1 2019, 12:09 PM

Thanks for finding that.

LIB_TAG_DOIT is no cleared before use while the comment in DNA_ID.h says that it should be.

I suggest to use BLI_gset_ptr_new with scene pointers instead since this kind of tagging is not ideal for thread safety or COW.

This revision now requires changes to proceed.Mar 1 2019, 12:09 PM

replace id tagging with tracking already rendered scenes in a GSet

This revision is now accepted and ready to land.Mar 1 2019, 12:44 PM
This revision was automatically updated to reflect the committed changes.